From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pMLWP-000753-B4 for mharc-qemu-riscv@gnu.org; Sun, 29 Jan 2023 23:11:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMLWO-00074Y-1k for qemu-riscv@nongnu.org; Sun, 29 Jan 2023 23:11:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMLWM-00014N-Jt for qemu-riscv@nongnu.org; Sun, 29 Jan 2023 23:11:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675051912; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=MGdaT5bvuLQsbnKTmhYEgxvxJGVouGB8/uGbyCZ1Syk=; b=gXFDob/+ms3ifJV8Kk5KlIzk6Z3SlWZKcTxgmzCNUdUv8m9pQ42cNIoq6+U6qBDp6wc/Sk jaKyNGXk7O6qHLxSgj5wF2uWT7HMuIg3OqS6dKYpv5YZbvSQmt08EcQvPtW6CYP0pscs1k 97vYvSlOwkZrqtfg8tBKWVxbHLljW+w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-407-woSQVGbxNMqeU5UL-LgFyA-1; Sun, 29 Jan 2023 23:11:51 -0500 X-MC-Unique: woSQVGbxNMqeU5UL-LgFyA-1 Received: by mail-wm1-f69.google.com with SMTP id bd21-20020a05600c1f1500b003dc5cb10dcfso293515wmb.9 for ; Sun, 29 Jan 2023 20:11:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:reply-to:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MGdaT5bvuLQsbnKTmhYEgxvxJGVouGB8/uGbyCZ1Syk=; b=5GRV4WCWvQCQyibUbksyvpn+1jDd/3sOt3Obth/aZxqh7o4DjMf/531dOm2nTHcWax AKx0PlL3AqzzLySexCfj5q+/Bx1ZmyxzM6LT+jV5n5XT5kC07OtKNxPc7+y1kARjbuVu X9Amn//ZPb9keeOeamU3iBfVELXyOsAq7UHx9TDxeuV5dtPNQVlwbWWzlmduJVFilfJj YhjspWzG7BNlW+YDtBa3GCMoJviETtvYWbRc1v48Kvex7ot2UG3rUXALxwb6xp7XChNf 24T/39u8MgYnNK4YJ0Vl949j1zzu/NRhr5pfCHB4hLxFnXYYXRNh/zHI9eSUBx7W7L4W YTbg== X-Gm-Message-State: AO0yUKVFfpNy+9BsRmul4vWyqpK5rZQINJ8/484tWLq6Os5R+xPFfO4d q+869u5bgTINYyRytG2ixE0X9jwPBUkHemyQDJ6izqJMYqB9e+QueEoiv3UVRZE87pG85utxjyi zchQIiJiyNEvQnuI= X-Received: by 2002:a05:600c:1c9f:b0:3dc:5aa8:952e with SMTP id k31-20020a05600c1c9f00b003dc5aa8952emr1331270wms.21.1675051910044; Sun, 29 Jan 2023 20:11:50 -0800 (PST) X-Google-Smtp-Source: AK7set9PrQoiJWa4Jju2OJXeaQpCMAKn/3ZFDL05ufOnJUvHZgjK5BymTZTePkBgeWvTc4M9o00Dbw== X-Received: by 2002:a05:600c:1c9f:b0:3dc:5aa8:952e with SMTP id k31-20020a05600c1c9f00b003dc5aa8952emr1331245wms.21.1675051909833; Sun, 29 Jan 2023 20:11:49 -0800 (PST) Received: from redhat.com ([46.136.252.173]) by smtp.gmail.com with ESMTPSA id l4-20020a7bc444000000b003db03725e86sm11403628wmi.8.2023.01.29.20.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 20:11:49 -0800 (PST) From: Juan Quintela To: Markus Armbruster Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, richard.henderson@linaro.org, pbonzini@redhat.com, kwolf@redhat.com, hreitz@redhat.com, imp@bsdimp.com, kevans@freebsd.org, berrange@redhat.com, groug@kaod.org, qemu_oss@crudebyte.com, mst@redhat.com, philmd@linaro.org, peter.maydell@linaro.org, alistair@alistair23.me, jasowang@redhat.com, jonathan.cameron@huawei.com, kbastian@mail.uni-paderborn.de, michael.roth@amd.com, kkostiuk@redhat.com, tsimpson@quicinc.com, palmer@dabbelt.com, bin.meng@windriver.com, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org Subject: Re: [PATCH v4 10/19] migration: Clean up includes In-Reply-To: <87wn5hoeqf.fsf@pond.sub.org> (Markus Armbruster's message of "Fri, 20 Jan 2023 08:19:04 +0100") References: <20230119065959.3104012-1-armbru@redhat.com> <20230119065959.3104012-11-armbru@redhat.com> <87wn5ivmru.fsf@pond.sub.org> <87wn5hoeqf.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Reply-To: quintela@redhat.com Date: Mon, 30 Jan 2023 05:11:48 +0100 Message-ID: <87bkmgpsor.fsf@secure.mitica> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2023 04:11:56 -0000 Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > >> * Markus Armbruster (armbru@redhat.com) wrote: >>> "Dr. David Alan Gilbert" writes: >>> >>> > * Markus Armbruster (armbru@redhat.com) wrote: >>> >> Clean up includes so that osdep.h is included first and headers >>> >> which it implies are not included manually. >>> > >>> > That change doesn't seem to match the message; the patch is removing the >>> > osdep.h include. >>> >>> It's the commit message scripts/clean-includes creates :) >>> >>> I can throw in another patch to the script so it mentions it also >>> removes qemu/osdep.h from headers. >> >> Oh hmm it would be clearer; > > What about > > $GITSUBJ: Clean up includes > > Clean up includes so that osdep.h is included first in .c and not in > .h, and headers which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > >> but OK then, so >> >> Reviewed-by: Dr. David Alan Gilbert Sounds ok to me. Reviewed-by: Juan Quintela