From: Alistair Francis <alistair23@gmail.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"open list:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH] target/riscv: csr: Rename HCOUNTEREN_CY and friends
Date: Thu, 16 Sep 2021 14:42:24 +1000 [thread overview]
Message-ID: <CAKmqyKNVC-CC06qPM_TtgwMPMnY-3=+D+-FKxEtkxDVMLd78=g@mail.gmail.com> (raw)
In-Reply-To: <20210915084601.24304-1-bmeng.cn@gmail.com>
On Wed, Sep 15, 2021 at 6:47 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The macro name HCOUNTEREN_CY suggests it is for CSR HCOUNTEREN, but
> in fact it applies to M-mode and S-mode CSR too. Rename these macros
> to have the COUNTEREN_ prefix.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> target/riscv/cpu_bits.h | 8 ++++----
> target/riscv/csr.c | 24 ++++++++++++------------
> 2 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
> index 7330ff5a19..34564d367c 100644
> --- a/target/riscv/cpu_bits.h
> +++ b/target/riscv/cpu_bits.h
> @@ -397,10 +397,10 @@
> #define HSTATUS32_WPRI 0xFF8FF87E
> #define HSTATUS64_WPRI 0xFFFFFFFFFF8FF87EULL
>
> -#define HCOUNTEREN_CY (1 << 0)
> -#define HCOUNTEREN_TM (1 << 1)
> -#define HCOUNTEREN_IR (1 << 2)
> -#define HCOUNTEREN_HPM3 (1 << 3)
> +#define COUNTEREN_CY (1 << 0)
> +#define COUNTEREN_TM (1 << 1)
> +#define COUNTEREN_IR (1 << 2)
> +#define COUNTEREN_HPM3 (1 << 3)
>
> /* Privilege modes */
> #define PRV_U 0
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index 50a2c3a3b4..1cd34a6453 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -71,20 +71,20 @@ static RISCVException ctr(CPURISCVState *env, int csrno)
> if (riscv_cpu_virt_enabled(env)) {
> switch (csrno) {
> case CSR_CYCLE:
> - if (!get_field(env->hcounteren, HCOUNTEREN_CY) &&
> - get_field(env->mcounteren, HCOUNTEREN_CY)) {
> + if (!get_field(env->hcounteren, COUNTEREN_CY) &&
> + get_field(env->mcounteren, COUNTEREN_CY)) {
> return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
> }
> break;
> case CSR_TIME:
> - if (!get_field(env->hcounteren, HCOUNTEREN_TM) &&
> - get_field(env->mcounteren, HCOUNTEREN_TM)) {
> + if (!get_field(env->hcounteren, COUNTEREN_TM) &&
> + get_field(env->mcounteren, COUNTEREN_TM)) {
> return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
> }
> break;
> case CSR_INSTRET:
> - if (!get_field(env->hcounteren, HCOUNTEREN_IR) &&
> - get_field(env->mcounteren, HCOUNTEREN_IR)) {
> + if (!get_field(env->hcounteren, COUNTEREN_IR) &&
> + get_field(env->mcounteren, COUNTEREN_IR)) {
> return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
> }
> break;
> @@ -98,20 +98,20 @@ static RISCVException ctr(CPURISCVState *env, int csrno)
> if (riscv_cpu_is_32bit(env)) {
> switch (csrno) {
> case CSR_CYCLEH:
> - if (!get_field(env->hcounteren, HCOUNTEREN_CY) &&
> - get_field(env->mcounteren, HCOUNTEREN_CY)) {
> + if (!get_field(env->hcounteren, COUNTEREN_CY) &&
> + get_field(env->mcounteren, COUNTEREN_CY)) {
> return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
> }
> break;
> case CSR_TIMEH:
> - if (!get_field(env->hcounteren, HCOUNTEREN_TM) &&
> - get_field(env->mcounteren, HCOUNTEREN_TM)) {
> + if (!get_field(env->hcounteren, COUNTEREN_TM) &&
> + get_field(env->mcounteren, COUNTEREN_TM)) {
> return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
> }
> break;
> case CSR_INSTRETH:
> - if (!get_field(env->hcounteren, HCOUNTEREN_IR) &&
> - get_field(env->mcounteren, HCOUNTEREN_IR)) {
> + if (!get_field(env->hcounteren, COUNTEREN_IR) &&
> + get_field(env->mcounteren, COUNTEREN_IR)) {
> return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
> }
> break;
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-09-16 4:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:46 [PATCH] target/riscv: csr: Rename HCOUNTEREN_CY and friends Bin Meng
2021-09-16 4:42 ` Alistair Francis [this message]
2021-09-16 21:41 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKNVC-CC06qPM_TtgwMPMnY-3=+D+-FKxEtkxDVMLd78=g@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).