From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF987C79F80 for ; Fri, 4 Sep 2026 07:57:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x2Omx-0001HO-3a; Fri, 04 Sep 2026 03:56:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2Omt-0001Gu-SJ for qemu-riscv@nongnu.org; Fri, 04 Sep 2026 03:56:39 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x2Omr-0005La-NP for qemu-riscv@nongnu.org; Fri, 04 Sep 2026 03:56:39 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-2cfbbdfa60bso6248585ad.3 for ; Fri, 04 Sep 2026 00:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1788508596; x=1789113396; darn=nongnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=hY6Ergdlpxyre9E9Lm5SEKbkPTMzytnQhnGeCLpki1M=; b=Gg+bwfu5uKce9z4bx0nl/yXdJhE8TNKEUlCMo3UmABkjACNWwfrw9aZK+zVgbdFFRX 1jHkN97sQ/H5nilL+ELyKY1xSTCNOIaXX6EDHXKhXqvJEN9n7aSbrYYP+yvFpt7OxpNI T/me7GPXHgYQRHhksjLdh+dgX+OJAFoWWiHm4FF5cR9suGwcIXLkO2v/ohGNsX2D4fuu lmDrmJOO2uA0l5oVPuiyTJP/9UWh7cF3a8Im78s82Zsu8Agvt13P4OQ8jHEoVAA4thp6 9vRpoxGPOGllbjLfzBrFhgfkjTPjogcsLC6qrSQ7BwB+3woWvoSRurQUEf725wcVLBMy 75pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788508596; x=1789113396; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=hY6Ergdlpxyre9E9Lm5SEKbkPTMzytnQhnGeCLpki1M=; b=Jdfnbd6wzqdbrD8ztDtwQgFTmFPxa47LrCbfQocXGhswCNuYpcOX3WQRMaYNiF9yPG CvfrfnJjirX46cqmAFEpU1/73tCC7fqQLsK9gqiW1EHyMpWadvIijasw3Dav1ADMI1WB azYNDR5uQFh8L7FltuHVuDsyhxNypllCGEBsYPSiVEpTbwfQGJfDzZ70GeRp9wi3HFs7 FbVkJ6dkFSbG4eEQzeLVhH5dbieg/ui1sxFxEqalN+HYr4jLvltYhDCKlRNpoQJKMNN5 ETESbHkeZKT1Oa1yNeCFHAne2BXJhsGNFyOHtBOd0GNcNbYYgFMf3k7VDjZ/KshMpRuj 0GNw== X-Forwarded-Encrypted: i=1; AKwUvByqKFQW6fI8Q28Lp6bDDGLQouZYrzRsiWRzoh1jOGXgd277uqLLVgPSWlUiOHsK9nSDm21Taq3MDcA/@nongnu.org X-Gm-Message-State: AFuF++kHxHmMotVBAkb/R7YqHtEkskad5+uXhinLui57X33TDG23TFUH 6+c1IOMosJtG64H2I6LLd8BLupYiJFdZD9tvW87GyIZnE1O2xMo+A7reQKcCSirsrpg= X-Gm-Gg: AYBFou0pzCBO5yJQKJc1AUmZcQzH8rnJo2WjoaVCWSX3dhwAZwlqT/LZi1tZP5Rey42 /m9tQiPVGZt2KHwMYSDE1vrP0rLZXUbMBJACzJnm+bJPb/UxfrQ99Lesj2dgwU86s2+TDutuW2e LlSFfqraiJYnpju5wleoiQ2GsWrHABrWUziUXv0M2PX/3D/niyfege9REUS8I15FdO/X3N91MWT wBhd3bqHWl5LWZr0doEgae7gHoT/al6K6vmgfTHKwcIUOVI1rZM20iMaiWqZI7Ok05T0x8JZ52P n28LAVEDvpo8/mYvNNONsPzbSTwhAbFxo99El7cKNWRQHQBoGPbSIbIoxA0TIYCfGW/BrnRAmDA sXifeEdIHk1R1AizdTWnfxgSPDANsm/X4A7eY1aE0mXD9La4xhRZSucUz5LkaMDyB0Le7oVmygJ bsVvFdHPxL2RYaXqGaQBDt3VSN57pVQBN55/c2n1uTgns95LSjl7HqcKmYjn3fr2n3RSM9rZV+C HhXrthQKAJXSVLy3sQpdJzjId+RjGxAsA== X-Received: by 2002:a17:90b:5243:b0:38e:c232:9d3f with SMTP id 98e67ed59e1d1-39b2614df1emr7538788a91.5.1788508595676; Fri, 04 Sep 2026 00:56:35 -0700 (PDT) Received: from sifive.com ([136.226.240.165]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39b08c397b1sm9357635a91.8.2026.09.04.00.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2026 00:56:35 -0700 (PDT) Date: Fri, 4 Sep 2026 15:56:32 +0800 From: Max Chou To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Daniel Henrique Barboza , Richard Henderson Subject: Re: [PATCH 1/2] tcg/riscv64: Validate AUIPC relocation range Message-ID: References: <20260903170405.3632015-1-max.chou@sifive.com> <20260903170405.3632015-2-max.chou@sifive.com> <8e3baf27-9e44-4481-b60a-06e33678d473@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e3baf27-9e44-4481-b60a-06e33678d473@oss.qualcomm.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=max.chou@sifive.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 2026-09-03 19:31, Philippe Mathieu-Daudé wrote: > > +static bool reloc_call(tcg_insn_unit *src_rw, const tcg_insn_unit *target) > > +{ > > + intptr_t hi, lo; > > - if (offset == hi + lo) { > > + if (split_auipc_offset(src_rw, target, &hi, &lo)) { > > src_rw[0] |= encode_uimm20(hi); > > src_rw[1] |= encode_imm12(lo); > > I'm a bit confused by these encode_*imm() taking uint32_t arguments, > otherwise your change LGTM: > Reviewed-by: Philippe Mathieu-Daudé > Hi Philippe, Thanks for the feedback. I’ll address that data type mismatch and send out a v2. rnax