From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lj5xC-0002bt-MV for mharc-qemu-riscv@gnu.org; Tue, 18 May 2021 16:04:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj56Q-0005d5-0t for qemu-riscv@nongnu.org; Tue, 18 May 2021 15:10:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj56J-0001cJ-02 for qemu-riscv@nongnu.org; Tue, 18 May 2021 15:10:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621364991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwByx8C8msqjMmho85FgN1xrYCdmXBYqdKwFSOKVW6A=; b=SCVWoxNC28TmlkLFbeyG2dgaoqsTfw8s3uo1WaLyaPmMvHZ7LVHy8BdrS45tR3aSDmWyk5 +Ec7OicHadiXvARy9z/owRpa/bmFrpAe1jOb8yA5q22E3yhExDxNTwLO23GZhPJVDCDt6Y ULpmL1gaDJtXEO7tqV5m/34nhcm9r50= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-fORRYkyDO5W6X8AcSdhgLg-1; Tue, 18 May 2021 15:09:49 -0400 X-MC-Unique: fORRYkyDO5W6X8AcSdhgLg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA183180FD61; Tue, 18 May 2021 19:09:47 +0000 (UTC) Received: from [10.10.117.64] (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59E34687E0; Tue, 18 May 2021 19:09:45 +0000 (UTC) Subject: Re: [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , Bin Meng , "open list:IDE" References: <20210515173716.358295-1-philmd@redhat.com> <20210515173716.358295-3-philmd@redhat.com> From: John Snow Message-ID: Date: Tue, 18 May 2021 15:09:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210515173716.358295-3-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 18 May 2021 16:04:32 -0400 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 19:10:02 -0000 On 5/15/21 1:37 PM, Philippe Mathieu-Daudé wrote: > The pci_ide_create_devs() function is declared i hw/ide/qdev.c: > > $ git grep ide_create_drive > hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); > hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive) > include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive); > > Fix the correct symbol dependency to avoid build failure when > deselecting some machines: > > /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_devs': > hw/ide/pci.c:491: undefined reference to `ide_create_drive' > > Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") > Acked-by: Paolo Bonzini > Reviewed-by: Bin Meng > Signed-off-by: Philippe Mathieu-Daudé Acked-by: John Snow > --- > hw/ide/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig > index 8e2c8934549..dd85fa3619f 100644 > --- a/hw/ide/Kconfig > +++ b/hw/ide/Kconfig > @@ -8,7 +8,7 @@ config IDE_QDEV > config IDE_PCI > bool > depends on PCI > - select IDE_CORE > + select IDE_QDEV > > config IDE_ISA > bool >