From: Richard Henderson <richard.henderson@linaro.org>
To: Alistair Francis <alistair.francis@opensource.wdc.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: bmeng.cn@gmail.com, palmer@dabbelt.com, alistair.francis@wdc.com,
alistair23@gmail.com
Subject: Re: [PATCH v1 2/2] target/riscv: Set mtval and stval support
Date: Fri, 3 Sep 2021 19:05:57 +0200 [thread overview]
Message-ID: <c2a74b35-70ad-d41a-26f9-3af2a8ce775d@linaro.org> (raw)
In-Reply-To: <968ed1af9002f5f9f42f9efe8a5db5a1ed830a09.1630624983.git.alistair.francis@wdc.com>
On 9/3/21 1:23 AM, Alistair Francis wrote:
> + DEFINE_PROP_BOOL("mtval_inst", RISCVCPU, cfg.mtval_inst, true),
Dash not underscore for the prop name, I think.
r~
next prev parent reply other threads:[~2021-09-03 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 23:23 [PATCH v1 0/2] RISC-V: Populate mtval and stval Alistair Francis
2021-09-02 23:23 ` [PATCH v1 1/2] target/riscv: Implement the stval/mtval illegal instruction Alistair Francis
2021-09-03 17:04 ` Richard Henderson
2021-09-04 13:41 ` Bin Meng
2021-09-02 23:23 ` [PATCH v1 2/2] target/riscv: Set mtval and stval support Alistair Francis
2021-09-03 17:05 ` Richard Henderson [this message]
2021-09-03 23:58 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a74b35-70ad-d41a-26f9-3af2a8ce775d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@opensource.wdc.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).