From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQAkg-0002Sq-7l for mharc-qemu-riscv@gnu.org; Tue, 14 Sep 2021 11:53:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQAke-0002O5-6o for qemu-riscv@nongnu.org; Tue, 14 Sep 2021 11:53:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38734) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQAkb-0003lP-Bp for qemu-riscv@nongnu.org; Tue, 14 Sep 2021 11:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631634816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6hUwwzfi7ZCFW20LiJr9iIjQbHTM6ICVlhLWMEND5eY=; b=F/yKRAahJSGmOC+x0OtFIhZimzJkqFPFbX4qI8jhLAWq43aNvtPFMV5UMS4GZki6txKFUO k7xfhDrrNxUFY7XDlHulK4Xw/qbQmWtQaUlQeJBGCvVR4iFLdFAe91R812J/tBIcR+Srca sGgZNh+1zQRg1OLmvdIIQ2WOeITMyfw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-lr9-pAnkNDi52JPlp_dN7w-1; Tue, 14 Sep 2021 11:53:35 -0400 X-MC-Unique: lr9-pAnkNDi52JPlp_dN7w-1 Received: by mail-wr1-f72.google.com with SMTP id i4-20020a5d5224000000b0015b14db14deso4117830wra.23 for ; Tue, 14 Sep 2021 08:53:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6hUwwzfi7ZCFW20LiJr9iIjQbHTM6ICVlhLWMEND5eY=; b=2/Z5fNyiDuywuic3xLcxMqtdjhHt9S849cB0Ah6NkPMbAtMqv9PW42JRi97XEh5PGE R/gykVQCtj0hkWjq+bPLxt8uoXpRUS0dMR01RQkvxjd6K+n0mlU837wQYFiQuBTM8xyw g6pCJPx6HrzPPk+muh0jVJc+CvUljoK3d+duCSQy+5F+B9G5WsDBaztykk30xPKnt8x/ 6LP3PYD+ANBuTReQ9dcNlXzUFVguhpitRir9FUEQq+eD83OX0GgGuo9VkYhgvoqlUIhs 6sYayYBgay/TkSaVr0Kyedxj7V06jdAELGTmgG4bKP39LWrTHqke6leHP20z1s7Pp4LL 9+7g== X-Gm-Message-State: AOAM530hrnkdrOVbTn2kGqhLXSkkaT7ivK973OaGYfv7FXy2yHagZ9uJ DjRlE0iYWIWRjuUsEgBIXaWhkTvHaDpBwSwGXK+tVsETAlVQt1u+vohNFjJb+89pplP+qgyVEYj RI0yBUKrN+56t2sM= X-Received: by 2002:a5d:63d2:: with SMTP id c18mr19252650wrw.311.1631634814297; Tue, 14 Sep 2021 08:53:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHHNaPVddGYd3jAil39+4NY0g1upviTmy4TdnEsM1WbSlcVhAV279zp7hUBa0vYHP7SnHymw== X-Received: by 2002:a5d:63d2:: with SMTP id c18mr19252627wrw.311.1631634814088; Tue, 14 Sep 2021 08:53:34 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id a10sm10977861wrd.51.2021.09.14.08.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 08:53:33 -0700 (PDT) Subject: Re: [PATCH v2 06/53] hw/core: introduce 'format_state' callback to replace 'dump_state' To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-7-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 14 Sep 2021 17:53:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914142042.1655100-7-berrange@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 15:53:40 -0000 On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > The 'dump_state' callback assumes it will be outputting to a FILE > object. This is fine for HMP, but not so useful for QMP. Introduce > a new 'format_state' callback that returns a formatted GString > instead. > > Signed-off-by: Daniel P. Berrangé > --- > hw/core/cpu-common.c | 15 +++++++++++++++ > include/hw/core/cpu.h | 13 ++++++++++++- > 2 files changed, 27 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé