From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mMEph-0004ZD-Kh for mharc-qemu-riscv@gnu.org; Fri, 03 Sep 2021 15:26:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMEpa-0004XU-Nr for qemu-riscv@nongnu.org; Fri, 03 Sep 2021 15:26:32 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:54262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMEpY-0007My-Rx for qemu-riscv@nongnu.org; Fri, 03 Sep 2021 15:26:30 -0400 Received: by mail-wm1-x332.google.com with SMTP id i3so4154250wmq.3 for ; Fri, 03 Sep 2021 12:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fEOMvnRt3u1MPJ0C48yTmkBQGXP7tFiEG+N6OQmYsjo=; b=P2pSCTQReq/NfuXlGzp+sOy6fpIESWIEw5CfGmWWhoHA6QU+aMtGRPT5QwL3G7cqaX qlsJZNSo19g2KqvrO+0vsMCULVfBC1SABLzWXL3a52khd1/0oDU5kA8ctU2xTA2t2tJg TFzPP5t9Z0ipMKdEPUNDpIthHRx7kRD5sydRKqae+dDdnRI3e3deHofjj3Dbhwx575FJ 67HrHdc6flCcR1dTNOCqIgJe8YuQnAbaVUFvr1U0suIQSXf+wJ2/6/OFYotwZQAmxKck fROsg+wFBaKOY8CGviS1GZZW/PbZy2B4duETnBoUcub93bFwOnrH0QDrH6sINCV4Iy4E ZREQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fEOMvnRt3u1MPJ0C48yTmkBQGXP7tFiEG+N6OQmYsjo=; b=qqAOyA2HKmlXZUQ2jSQLnnHA93iVsdlhbMfn1KB/0tnjSo0ner58IiFSRvqtzgKzuB anA/U0M+D9KfeRgu1xU4zsOWDpypaVgo3Pi1WPVjlrTV5ECTC7NIkwRjVzdidCLd74mM ahyKFSzTZLiqJSDjx6BBZ3laCbzOpEQb+GasJqwRSt68HdZD/KWLEBcNJeq35ookRa5a 7gLgUkNxwAoGr9XOWAreWnysgf5QLaowVnXdcbpN/XfvmGF6GSeWzVzbxZ0u3L2/UsOG cEVXxXUa6bVWEbx0vKUzL4xmNtLwJby+B6mR9WcuJC/4I/0Muvn5U74YA3TfpWamTy+U g7Lg== X-Gm-Message-State: AOAM531G3trJvQHu/EoT6PlXWGebTwHdg3zlofr7cY1Knd7nTp61VNcx uOwp/OGGP5Ma6BKlIlg29Yh2Vw== X-Google-Smtp-Source: ABdhPJzPb7c7nn36sN0yMAj5ZlOkqXuuz0MVoi48d+Irv6UFiriYZ9JbXNphN9ib9SQl4UPKFUyy2g== X-Received: by 2002:a7b:c255:: with SMTP id b21mr296138wmj.44.1630697186866; Fri, 03 Sep 2021 12:26:26 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id f17sm134080wrt.63.2021.09.03.12.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 12:26:26 -0700 (PDT) Subject: Re: [PATCH 23/24] accel/tcg: Restrict TCGCPUOps::cpu_exec_interrupt() to sysemu To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Yoshinori Sato , Jiaxun Yang , qemu-arm@nongnu.org, Palmer Dabbelt , Max Filippov , Warner Losh , Michael Rolnik , Stafford Horne , Paolo Bonzini , "Edgar E. Iglesias" , Bin Meng , Chris Wulff , Mark Cave-Ayland , David Gibson , Kyle Evans , Peter Maydell , Aurelien Jarno , Eduardo Habkost , Marek Vasut , Artyom Tarasenko , Aleksandar Rikalo , Greg Kurz , qemu-riscv@nongnu.org, Laurent Vivier , qemu-ppc@nongnu.org, Alistair Francis References: <20210902151715.383678-1-f4bug@amsat.org> <20210902151715.383678-24-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 21:26:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902151715.383678-24-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.888, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 19:26:32 -0000 On 9/2/21 5:17 PM, Philippe Mathieu-Daudé wrote: > All targets call TCGCPUOps::cpu_exec_interrupt() from sysemu code. > Move its declaration to restrict it to system emulation. > Extend the code guarded and remove the user-mode assertion. > Also restrict the static inlined need_replay_interrupt() method to > avoid a "defined but not used" warning. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/tcg-cpu-ops.h | 4 ++-- > accel/tcg/cpu-exec.c | 13 +++++++------ > 2 files changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~