From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D814CAC5BA for ; Thu, 25 Sep 2025 19:42:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1rqg-0002tF-GC; Thu, 25 Sep 2025 15:41:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1rqb-0002rJ-Fb for qemu-rust@nongnu.org; Thu, 25 Sep 2025 15:41:45 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1rqW-0000cn-2O for qemu-rust@nongnu.org; Thu, 25 Sep 2025 15:41:44 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-77f198bd8eeso1083273b3a.3 for ; Thu, 25 Sep 2025 12:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758829295; x=1759434095; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KWF7dYDz3Kuuo7uE3AqpQg0oa/WgI91fAuksLxrlHOI=; b=rCITKKy972TAHUiqDe2LaHf/oTF/sMOixd8ZVNIdfbsfXnciXcxhqRkuRQdVv8pVr4 ThvR3RSD8xU3Q7x5JZ3HHW9DmxCmvzLOgELCkcZXYDm7UXLrQkoEPFG0Cesncw6zOBgg 5Pst0wKC8Qy8J1PvTbsE+KP1NI76Iyl1dIaPw6MwF6mbj0l6S0L97RUJNPg9YkSMIpA7 QFJpeOjzAz0Da47D+uS6geL9r/eNvhedH1nKVaRbJN2nilOkwwTl71TzmaLBsrJIgCfn gX9fVO0YWu6u+igAp3wLiAlMH0UUBPqmBRmjnXVEIIuXw8g9L8wnhnKwtcuvRIyb5V1j YNPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758829295; x=1759434095; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KWF7dYDz3Kuuo7uE3AqpQg0oa/WgI91fAuksLxrlHOI=; b=Fan2axtXYaU6OnkiESDcNYfadktofZATgxbhrN/SxnXlPjQHorgQgfbWgdoId4+URZ BsYiav4jLB1lZfngIpflSCH4UvDm4Uim9pLDdAm0uxkabV6pus8T4TNUuJQy0pK4MLiA m3sDiB2hh4LO/WzKPXun7Gb3ywOFmXMyyTEf3zffsSRAc3H9bGSgYR4m/A/aErDg2jkn Qmp2ecGAPksx+TgO0uzfZKZk3nG9GbLfIHE+OQLTNy69X/s9u+JmEIRvQKbrkSO3uaLF gNQdxBzl+bIrtdD0oS1rNdOUa9kxFFTb9sZO5dprojwdph1qfFbIG8HrdW1odaRDNHyK cYfw== X-Forwarded-Encrypted: i=1; AJvYcCX2RCCOwFXb+tNMAqWSlH/GfGcIr/aywUb1s96oX1Ep3A+/qsgK0l/eCZcT6qxfL0HiPPAImIU1Ack=@nongnu.org X-Gm-Message-State: AOJu0YwlrnRbAHEVSFyyH2OzBP2sKLjFKLZHcyNey6kb/hJe5C6Uu7eD m6ZnUSIJfU0FQ2gf7OfNV/xCESaPAaXYnF2QE5bsQmSsAa8CeeKmMWE5DTXiSXkOT5A= X-Gm-Gg: ASbGncu32r0BEIBbxy48fmdWtpi+jbrqJXyygojsHY+3vaZsKX00vqbfj7FX2g1SHUB BjE6vMR9/22A+9EJkFNBFIeCL2U1PzqvK4+NqRZ04zRCyn6oLq+ywqhMCoVvFxBuin+EcWgEIoD Xoo7UQEVMsY3siQtCFG3wkIZd20pcAkRz53d9SzVbR3Wnr8b+Ti1OARt95bsnBISVkXewsDzFfM 6Dyr5sVBbnSLZKhsyd+mwyQkMLSZi/+/cGeutyyQQehMv0v7jk/nVppwXteZpkwUmOb0njCdjzU H9bWd19AkkiZm3CUmIWzrs4MM1wfvyWnQm6TxVFYkWF0dR5+KOLEnHuKCPJ8fTuyJF55aI+2OwQ DoBYYFCwqZXqDN8HeG7UE5gZuGND56/73jtQa X-Google-Smtp-Source: AGHT+IFp8anHItOeMFnQQIXkudQYYOeYMRgr63kmR4raIoKErwKvKdu8E4meRh5IZnOuCP3MxmBhrA== X-Received: by 2002:a05:6a00:2e99:b0:77f:deaa:3570 with SMTP id d2e1a72fcca58-780fcddc9b5mr5461740b3a.2.1758829295526; Thu, 25 Sep 2025 12:41:35 -0700 (PDT) Received: from [192.168.0.4] ([71.212.157.132]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78102c2b70esm2511835b3a.101.2025.09.25.12.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 12:41:35 -0700 (PDT) Message-ID: <180302d9-002d-4188-a100-fbcac7a7aadd@linaro.org> Date: Thu, 25 Sep 2025 12:41:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/23] monitor: introduce monitor_cur_is_hmp() helper To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org Cc: Hanna Reitz , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Kevin Wolf , qemu-rust@nongnu.org, Markus Armbruster , Christian Schoenebeck , qemu-block@nongnu.org, Stefan Weil , "Dr. David Alan Gilbert" , Manos Pitsidianakis , Gerd Hoffmann , devel@lists.libvirt.org, Paolo Bonzini References: <20250925094441.1651372-1-berrange@redhat.com> <20250925094441.1651372-15-berrange@redhat.com> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250925094441.1651372-15-berrange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On 9/25/25 02:44, Daniel P. Berrangé wrote: > Note that this is not simply the inverse of monitor_cur_is_qmp(), > as both helpers require that monitor_cur() is first non-NULL. > > Signed-off-by: Daniel P. Berrangé > --- > include/monitor/monitor.h | 1 + > monitor/monitor.c | 10 ++++++++++ > stubs/monitor-core.c | 6 ++++++ > tests/unit/test-util-sockets.c | 1 + > 4 files changed, 18 insertions(+) Reviewed-by: Richard Henderson r~