From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tG3Tm-00025b-UP for mharc-qemu-rust@gnu.org; Tue, 26 Nov 2024 16:52:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG36f-0001wq-Hr for qemu-rust@nongnu.org; Tue, 26 Nov 2024 16:28:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG36d-0004ch-9C for qemu-rust@nongnu.org; Tue, 26 Nov 2024 16:28:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732656501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2bVfuVSIsMKCKvriHIIacA8lNNZ42nxSlyRz3CpsIdY=; b=IdAhKopCIpwWLI+sxLYoBrPgziPpy8vUYXX0B4+EtdjBEe8tloMt0kJeuLvcWHRTi2Iy7m TuS6Vo4lx6o60weE3pLmSPlmNZ/NvqhbzXriCWqzYYdgN21oxfb0nvMeGRDihQ5zXtMtPm JHFwL4VF71dnicRooPsAdySlOv2tIxE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-rSKpb-ERMz6-ItcgXHGN9w-1; Tue, 26 Nov 2024 16:27:13 -0500 X-MC-Unique: rSKpb-ERMz6-ItcgXHGN9w-1 X-Mimecast-MFC-AGG-ID: rSKpb-ERMz6-ItcgXHGN9w Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4349df2d87dso27927265e9.2 for ; Tue, 26 Nov 2024 13:27:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732656432; x=1733261232; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2bVfuVSIsMKCKvriHIIacA8lNNZ42nxSlyRz3CpsIdY=; b=dK9dDPF+ljgzreUt0+hjITwWltloHN5XBJ4C2jD2Kfu2LP4BCQLLmYm7UuUJZZTIMW 51lRodmEkUR84RU3lGWZXxM3bmVJ7CsH18smK9yeNtQ8mmp41gRawMgsSqGsQLKiZVkk mrLwsvZbGq87UVJ2FgsHNtEcOcAtw/kcHNsizGJu/Iv5s0X7JVnB+yRAZAxXXFWDytco wjDPF37xn/NquULfPgacFl6cx34YD6LFsZ+B0kEYY4RchWS1cH8jCF5WegVyaSzzXzHC S8At+zqQXK+4A6UXquhybGt4zkt9P+J9GXF6sjC/6Zv8Chq72hsDzKTSU7yC9KzAjKWZ H4XQ== X-Forwarded-Encrypted: i=1; AJvYcCWdYaXysvZN/Aqs8MwzN/hcUibCrGay/3xzuWkTkOQWQyr5MyAUNyY/EM45coPP2f3zFYsHH25FTrY=@nongnu.org X-Gm-Message-State: AOJu0YzXY0HpaoZnI/xQED05MSSiQEorWt2gLnIt2/N/kigpvmW8Ib7r s1MTg/xNHBXHOvUt5lQQKRd+FC+rfFyspytNJ4vsFuWGoXbOgSktMJLIodJrPdAScGNB2acEeP3 MVl6pNIyPqDzRRFaeHCc69L8ZBam6zLTDAKUbvor6ss6mVUK/FDQ= X-Gm-Gg: ASbGncsT3qw6nyoCIBx4mBSxqZJTFWhZ9ZBSjyYpopWfxyv2Oaf5EKmmGMiij4sv6eL PNAyGIrQBfSmUM1bdXFd2715e3PDHQojrZAJnKPIOPF2414uSlWSTw+YHH8yFYUQCeuGey9SN2Q BqXTX4a+RYHTN0qieTiLX3v5d6Yfex6pXhu4L6Nk+QTPsmY+CLKGhJMY5cgA5urvI/VjWmPHa5F 85SkE/kS/m4PqutGu0kN3kEX1yk0I3IL50o0GHxWQ== X-Received: by 2002:a05:600c:2244:b0:434:a8ef:442e with SMTP id 5b1f17b1804b1-434a9dfbafamr7728885e9.31.1732656432460; Tue, 26 Nov 2024 13:27:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjgz2FgrmcINdKkoJfxex3YuSbGP/iA9vAVXo29xmjdAJIdEMvCSbnI4EQsP07JMl9b42HoA== X-Received: by 2002:a05:600c:2244:b0:434:a8ef:442e with SMTP id 5b1f17b1804b1-434a9dfbafamr7728705e9.31.1732656432034; Tue, 26 Nov 2024 13:27:12 -0800 (PST) Received: from redhat.com ([2a02:14f:1f0:4654:4e59:b33:d0e:9273]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4349ea54e13sm95116915e9.34.2024.11.26.13.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 13:27:10 -0800 (PST) Date: Tue, 26 Nov 2024 16:27:00 -0500 From: "Michael S. Tsirkin" To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: qemu-devel@nongnu.org, Peter Maydell , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Daniel Henrique Barboza , Pierrick Bouvier , Harsh Prateek Bora , Marcel Apfelbaum , Jiaxun Yang , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Alexandre Iooss , qemu-riscv@nongnu.org, Thomas Huth , Bernhard Beschow , Thomas Huth , Eric Farman , Bin Meng , qemu-s390x@nongnu.org, Niek Linnenbank , qemu-arm@nongnu.org, John Snow , Wainer dos Santos Moschetta , Cleber Rosa , qemu-rust@nongnu.org, Nicholas Piggin , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Palmer Dabbelt , Markus Armbruster , Weiwei Li , Mahmoud Mandour , Mark Cave-Ayland , Liu Zhiwei , Aurelien Jarno , Ani Sinha , Alistair Francis , Stefan Hajnoczi , Richard Henderson Subject: Re: [PATCH 39/39] docs: explicitly permit a "commonly known identity" with SoB Message-ID: <20241126162651-mutt-send-email-mst@kernel.org> References: <20241121165806.476008-1-alex.bennee@linaro.org> <20241121165806.476008-40-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20241121165806.476008-40-alex.bennee@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: b0sdH2iSo3Gk3Cx7hfUT43bzdOvI8nMHKv2Y-JC0diQ_1732656432 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 26 Nov 2024 16:52:17 -0500 X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2024 21:28:26 -0000 On Thu, Nov 21, 2024 at 04:58:06PM +0000, Alex Bennée wrote: > From: Daniel P. Berrangé > > The docs for submitting a patch describe using your "Real Name" with > the Signed-off-by line. Although somewhat ambiguous, this has often > been interpreted to mean someone's legal name. > > In recent times, there's been a general push back[1] against the notion > that use of Signed-off-by in a project automatically requires / implies > the use of legal ("real") names and greater awareness of the downsides. > > Full discussion of the problems of such policies is beyond the scope of > this commit message, but at a high level they are liable to marginalize, > disadvantage, and potentially result in harm, to contributors. > > TL;DR: there are compelling reasons for a person to choose distinct > identities in different contexts & a decision to override that choice > should not be taken lightly. > > A number of key projects have responded to the issues raised by making > it clear that a contributor is free to determine the identity used in > SoB lines: > > * Linux has clarified[2] that they merely expect use of the > contributor's "known identity", removing the previous explicit > rejection of pseudonyms. > > * CNCF has clarified[3] that the real name is simply the identity > the contributor chooses to use in the context of the community > and does not have to be a legal name, nor birth name, nor appear > on any government ID. > > Since we have no intention of ever routinely checking any form of ID > documents for contributors[4], realistically we have no way of knowing > anything about the name they are using, except through chance, or > through the contributor volunteering the information. IOW, we almost > certainly already have people using pseudonyms for contributions. > > This proposes to accept that reality and eliminate unnecessary friction, > by following Linux & the CNCF in merely asking that a contributors' > commonly known identity, of their choosing, be used with the SoB line. > > [1] Raised in many contexts at many times, but a decent overall summary > can be read at https://drewdevault.com/2023/10/31/On-real-names.html > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 > [3] https://github.com/cncf/foundation/blob/659fd32c86dc/dco-guidelines.md > [4] Excluding the rare GPG key signing parties for regular maintainers > > Signed-off-by: Daniel P. Berrangé > Acked-by: Stefan Hajnoczi > Acked-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Alex Bennée > Acked-by: Richard Henderson > Message-Id: <20241021190939.1482466-1-berrange@redhat.com> > Signed-off-by: Alex Bennée Acked-by: Michael S. Tsirkin > --- > docs/devel/submitting-a-patch.rst | 7 ++++++- > .gitlab-ci.d/check-dco.py | 5 ++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst > index 83e9092b8c..10b062eec2 100644 > --- a/docs/devel/submitting-a-patch.rst > +++ b/docs/devel/submitting-a-patch.rst > @@ -18,7 +18,7 @@ one-shot fix, the bare minimum we ask is that: > > * - Check > - Reason > - * - Patches contain Signed-off-by: Real Name > + * - Patches contain Signed-off-by: Your Name > - States you are legally able to contribute the code. See :ref:`patch_emails_must_include_a_signed_off_by_line` > * - Sent as patch emails to ``qemu-devel@nongnu.org`` > - The project uses an email list based workflow. See :ref:`submitting_your_patches` > @@ -335,6 +335,11 @@ include a "From:" line in the body of the email (different from your > envelope From:) that will give credit to the correct author; but again, > that author's Signed-off-by: line is mandatory, with the same spelling. > > +The name used with "Signed-off-by" does not need to be your legal name, > +nor birth name, nor appear on any government ID. It is the identity you > +choose to be known by in the community, but should not be anonymous, > +nor misrepresent whom you are. > + > There are various tooling options for automatically adding these tags > include using ``git commit -s`` or ``git format-patch -s``. For more > information see `SubmittingPatches 1.12 > diff --git a/.gitlab-ci.d/check-dco.py b/.gitlab-ci.d/check-dco.py > index d221b16bd5..70dec7d6ee 100755 > --- a/.gitlab-ci.d/check-dco.py > +++ b/.gitlab-ci.d/check-dco.py > @@ -78,7 +78,10 @@ > > To indicate acceptance of the DCO every commit must have a tag > > - Signed-off-by: REAL NAME > + Signed-off-by: YOUR NAME > + > +where "YOUR NAME" is your commonly known identity in the context > +of the community. > > This can be achieved by passing the "-s" flag to the "git commit" command. > > -- > 2.39.5