qemu-rust.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hanna Reitz" <hreitz@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	qemu-rust@nongnu.org,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-block@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	devel@lists.libvirt.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v4 23/23] util: add brackets around guest name in message context
Date: Thu, 25 Sep 2025 10:44:41 +0100	[thread overview]
Message-ID: <20250925094441.1651372-24-berrange@redhat.com> (raw)
In-Reply-To: <20250925094441.1651372-1-berrange@redhat.com>

The message context can optionally include the guest name if the
argument '-msg guest-name=on' is given. The formatting, however,
does not look good if the guest name contains whitespace. Change
the output to include square brackets to demarcate the name.

Before:

  # qemu-system-x86_64 -object tls-creds-x509,id=t0,dir=fish -d 'trace:qcrypto*' -msg guest-name=on -name "fish food"
  fish food qemu-system-x86_64: (1146846:main): qcrypto_tls_creds_x509_load TLS creds x509 load creds=0x55657e94e690 dir=fish
  fish food qemu-system-x86_64: (1146846:main): qcrypto_tls_creds_get_path TLS creds path creds=0x55657e94e690 filename=ca-cert.pem path=<none>
  fish food qemu-system-x86_64: (1146846:main): Unable to access credentials fish/ca-cert.pem: No such file or directory

After:

  # qemu-system-x86_64 -object tls-creds-x509,id=t0,dir=fish -d 'trace:qcrypto*' -msg guest-name=on -name "fish food"
  [fish food] qemu-system-x86_64: (1144713:main): qcrypto_tls_creds_x509_load TLS creds x509 load creds=0x5604ada2c950 dir=fish
  [fish food] qemu-system-x86_64: (1144713:main): qcrypto_tls_creds_get_path TLS creds path creds=0x5604ada2c950 filename=ca-cert.pem path=<none>
  [fish food] qemu-system-x86_64: (1144713:main): Unable to access credentials fish/ca-cert.pem: No such file or directory

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 util/message.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/message.c b/util/message.c
index 814ca0316e..7d94b9d970 100644
--- a/util/message.c
+++ b/util/message.c
@@ -28,7 +28,7 @@ void qmessage_context_print(FILE *fp)
 
     if ((message_format & QMESSAGE_FORMAT_WORKLOAD_NAME) &&
         message_workloadname) {
-        fprintf(fp, "%s ", message_workloadname);
+        fprintf(fp, "[%s] ", message_workloadname);
     }
 
     if (message_format & QMESSAGE_FORMAT_PROGRAM_NAME) {
-- 
2.50.1



  parent reply	other threads:[~2025-09-25  9:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  9:44 [PATCH v4 00/23] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 01/23] include: define constant for early constructor priority Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 02/23] monitor: initialize global data from a constructor Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 03/23] system: unconditionally enable thread naming Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 04/23] util: expose qemu_thread_set_name Daniel P. Berrangé
2025-09-25  9:52   ` Philippe Mathieu-Daudé
2025-09-25  9:44 ` [PATCH v4 05/23] audio: make jackaudio use qemu_thread_set_name Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 06/23] util: set the name for the 'main' thread Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 07/23] util: add API to fetch the current thread name Daniel P. Berrangé
2025-09-25 21:13   ` Eric Blake
2025-09-25  9:44 ` [PATCH v4 08/23] log: avoid repeated prefix on incremental qemu_log calls Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 09/23] util: introduce some API docs for logging APIs Daniel P. Berrangé
2025-09-25 21:18   ` Eric Blake
2025-09-25  9:44 ` [PATCH v4 10/23] ui/vnc: remove use of error_printf_unless_qmp() Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 11/23] monitor: remove redundant error_[v]printf_unless_qmp Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 12/23] monitor: refactor error_vprintf() Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 13/23] monitor: move error_vprintf back to error-report.c Daniel P. Berrangé
2025-09-25 21:20   ` Eric Blake
2025-09-25  9:44 ` [PATCH v4 14/23] monitor: introduce monitor_cur_is_hmp() helper Daniel P. Berrangé
2025-09-25 19:41   ` Richard Henderson
2025-09-25  9:44 ` [PATCH v4 15/23] util: don't skip error prefixes when QMP is active Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 16/23] util: fix interleaving of error & trace output Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 17/23] util: fix interleaving of error prefixes Daniel P. Berrangé
2025-09-25  9:56   ` Philippe Mathieu-Daudé
2025-09-25  9:44 ` [PATCH v4 18/23] util: introduce common helper for error-report & log code Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 19/23] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2025-09-25  9:44 ` [PATCH v4 20/23] util: add support for formatting a workload name in messages Daniel P. Berrangé
2025-09-25  9:59   ` Philippe Mathieu-Daudé
2025-09-25 11:25   ` Philippe Mathieu-Daudé
2025-09-25  9:44 ` [PATCH v4 21/23] util: add support for formatting a program " Daniel P. Berrangé
2025-09-25  9:59   ` Philippe Mathieu-Daudé
2025-09-25 11:23   ` Philippe Mathieu-Daudé
2025-09-25  9:44 ` [PATCH v4 22/23] util: add support for formatting thread info " Daniel P. Berrangé
2025-09-25 10:00   ` Philippe Mathieu-Daudé
2025-09-25  9:44 ` Daniel P. Berrangé [this message]
2025-09-25 10:01   ` [PATCH v4 23/23] util: add brackets around guest name in message context Philippe Mathieu-Daudé
2025-09-25 11:25     ` Philippe Mathieu-Daudé
2025-09-25 10:22 ` [PATCH v4 00/23] util: sync error_report & qemu_log output more closely Philippe Mathieu-Daudé
2025-09-25 10:31   ` Daniel P. Berrangé
2025-09-25 11:21     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250925094441.1651372-24-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=devel@lists.libvirt.org \
    --cc=hreitz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).