public inbox for qemu-rust@nongnu.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	devel@lists.libvirt.org, qemu-block@nongnu.org,
	qemu-rust@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>, "Kevin Wolf" <kwolf@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH v5 02/24] include: define constant for early constructor priority
Date: Thu,  8 Jan 2026 17:03:16 +0000	[thread overview]
Message-ID: <20260108170338.2693853-3-berrange@redhat.com> (raw)
In-Reply-To: <20260108170338.2693853-1-berrange@redhat.com>

Functions marked with __attribute__((__constructor__)) will be
invoked in linker order. In theory this is well defined, but
in practice, it is hard to determine what this order will be
with the layers of indirection through meson, ninja and the
static libraries QEMU builds.

Notably, the order currently appears different between Linux
and Windows (as tested with Wine on Linux). This can cause
problems when certain QEMU constructors have a dependancy on
other QEMU constructors.

To address this define a QEMU_CONSTRUCTOR_EARLY constant which
provides a priority value that will run before other default
constructors. This is to be used for QEMU constructors that
are themselves self-contained, but may be relied upon by other
constructors.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 include/qemu/compiler.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index 1c2b673c05..4c49f52eb0 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -194,6 +194,14 @@
 # define QEMU_USED
 #endif
 
+/*
+ * A priority for __attribute__((constructor(...))) that
+ * will run earlier than the default constructors. Must
+ * only be used for functions that have no dependency
+ * on global initialization of other QEMU subsystems.
+ */
+#define QEMU_CONSTRUCTOR_EARLY 101
+
 /*
  * Disable -ftrivial-auto-var-init on a local variable.
  *
-- 
2.52.0



  parent reply	other threads:[~2026-01-08 17:05 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 17:03 [PATCH v5 00/24] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 01/24] qemu-options: remove extraneous [] around arg values Daniel P. Berrangé
2026-01-13  7:47   ` Markus Armbruster
2026-01-08 17:03 ` Daniel P. Berrangé [this message]
2026-01-09 11:39   ` [PATCH v5 02/24] include: define constant for early constructor priority Paolo Bonzini
2026-01-09 11:46     ` Daniel P. Berrangé
2026-01-09 12:09       ` Paolo Bonzini
2026-01-13  9:04         ` Markus Armbruster
2026-01-13  9:32           ` Paolo Bonzini
2026-01-14 11:20             ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 03/24] monitor: initialize global data from a constructor Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 04/24] system: unconditionally enable thread naming Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 05/24] util: expose qemu_thread_set_name Daniel P. Berrangé
2026-01-13  9:16   ` Markus Armbruster
2026-01-13 10:41     ` Daniel P. Berrangé
2026-02-10 17:13     ` Daniel P. Berrangé
2026-02-11  5:56       ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 06/24] audio: make jackaudio use qemu_thread_set_name Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 07/24] util: set the name for the 'main' thread Daniel P. Berrangé
2026-01-09 11:45   ` Paolo Bonzini
2026-01-09 11:52     ` Daniel P. Berrangé
2026-01-09 12:04       ` Paolo Bonzini
2026-01-08 17:03 ` [PATCH v5 08/24] util: add API to fetch the current thread name Daniel P. Berrangé
2026-01-09 11:49   ` Paolo Bonzini
2026-01-09 11:56     ` Daniel P. Berrangé
2026-01-09 12:11       ` Paolo Bonzini
2026-01-13  9:27   ` Markus Armbruster
2026-01-13 10:00     ` Daniel P. Berrangé
2026-01-13 13:00       ` Markus Armbruster
2026-01-13 15:49         ` Paolo Bonzini
2026-01-14 11:28           ` Daniel P. Berrangé
2026-01-14 11:27         ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 09/24] util: introduce some API docs for logging APIs Daniel P. Berrangé
2026-01-13  9:59   ` Markus Armbruster
2026-01-13 10:49     ` Daniel P. Berrangé
2026-01-13 10:52       ` Daniel P. Berrangé
2026-01-13 13:04         ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 10/24] util: avoid repeated prefix on incremental qemu_log calls Daniel P. Berrangé
2026-01-13 10:19   ` Markus Armbruster
2026-01-13 11:56     ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 11/24] ui/vnc: remove use of error_printf_unless_qmp() Daniel P. Berrangé
2026-01-13 13:11   ` Markus Armbruster
2026-01-13 14:44   ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 12/24] monitor: remove redundant error_[v]printf_unless_qmp Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 13/24] monitor: refactor error_vprintf() Daniel P. Berrangé
2026-01-13 13:17   ` Markus Armbruster
2026-01-14 11:34   ` Markus Armbruster
2026-01-14 12:01     ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 14/24] monitor: move error_vprintf back to error-report.c Daniel P. Berrangé
2026-01-13 13:38   ` Markus Armbruster
2026-01-14 12:09     ` Daniel P. Berrangé
2026-01-14 13:13       ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 15/24] monitor: introduce monitor_cur_is_hmp() helper Daniel P. Berrangé
2026-01-13 14:57   ` Markus Armbruster
2026-01-14 12:46     ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 16/24] util: don't skip error prefixes when QMP is active Daniel P. Berrangé
2026-01-11 22:25   ` Richard Henderson
2026-01-13 15:19   ` Markus Armbruster
2026-01-14 12:53   ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 17/24] util: fix interleaving of error & trace output Daniel P. Berrangé
2026-01-11 22:28   ` Richard Henderson
2026-01-14 13:00   ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 18/24] util: fix interleaving of error prefixes Daniel P. Berrangé
2026-01-14 14:00   ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 19/24] util: introduce common helper for error-report & log code Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 20/24] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 21/24] util: add support for formatting a workload name in messages Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 22/24] util: add support for formatting a program " Daniel P. Berrangé
2026-01-11 22:31   ` Richard Henderson
2026-01-08 17:03 ` [PATCH v5 23/24] util: add support for formatting thread info " Daniel P. Berrangé
2026-01-11 22:32   ` Richard Henderson
2026-01-08 17:03 ` [PATCH v5 24/24] util: add brackets around guest name in message context Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108170338.2693853-3-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=devel@lists.libvirt.org \
    --cc=hreitz@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox