public inbox for qemu-rust@nongnu.org
 help / color / mirror / Atom feed
From: Mohd Kashif Khan <kashif04x@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-rust@nongnu.org, Mohd Kashif Khan <kashif04x@gmail.com>
Subject: [PATCH] rust/hpet: remove stale TODO comment
Date: Tue, 27 Jan 2026 02:39:10 +0530	[thread overview]
Message-ID: <20260126210910.28889-1-kashif04x@gmail.com> (raw)

The irq binding is already implemented in the following line, so the TODO comment is obsolete.

Signed-off-by: Mohd Kashif Khan <kashif04x@gmail.com>
---
 rust/hw/timer/hpet/src/device.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/device.rs
index 4757bf5fd5..ebf715d399 100644
--- a/rust/hw/timer/hpet/src/device.rs
+++ b/rust/hw/timer/hpet/src/device.rs
@@ -725,7 +725,6 @@ fn set_cfg_reg(&self, regs: &mut HPETRegisters, shift: u32, len: u32, val: u64)
             self.irqs[0].lower();
             self.irqs[RTC_ISA_IRQ].lower();
         } else if deactivating_bit(old_val, new_val, HPET_CFG_LEG_RT_SHIFT) {
-            // TODO: Add irq binding: qemu_irq_lower(s->irqs[0])
             self.irqs[0].lower();
             self.pit_enabled.set(true);
             self.irqs[RTC_ISA_IRQ].set(self.rtc_irq_level.get() != 0);
-- 
2.43.0



             reply	other threads:[~2026-01-26 21:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 21:09 Mohd Kashif Khan [this message]
2026-01-27  8:12 ` [PATCH] rust/hpet: remove stale TODO comment Zhao Liu
2026-01-27  9:37 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260126210910.28889-1-kashif04x@gmail.com \
    --to=kashif04x@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox