* [PATCH] gitlab-ci: include full Rust backtraces in test runs
@ 2025-01-29 8:20 Paolo Bonzini
2025-01-29 8:26 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Paolo Bonzini @ 2025-01-29 8:20 UTC (permalink / raw)
To: qemu-devel; +Cc: berrange, qemu-rust
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
.gitlab-ci.d/buildtest-template.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
index 39da7698b09..4cc19239319 100644
--- a/.gitlab-ci.d/buildtest-template.yml
+++ b/.gitlab-ci.d/buildtest-template.yml
@@ -63,6 +63,7 @@
stage: test
image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG
script:
+ - export RUST_BACKTRACE=1
- source scripts/ci/gitlab-ci-section
- section_start buildenv "Setting up to run tests"
- scripts/git-submodule.sh update roms/SLOF
--
2.48.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-01-29 8:20 [PATCH] gitlab-ci: include full Rust backtraces in test runs Paolo Bonzini
@ 2025-01-29 8:26 ` Thomas Huth
2025-01-29 8:26 ` Philippe Mathieu-Daudé
2025-03-10 9:21 ` Peter Maydell
2 siblings, 0 replies; 8+ messages in thread
From: Thomas Huth @ 2025-01-29 8:26 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: berrange, qemu-rust
On 29/01/2025 09.20, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitlab-ci.d/buildtest-template.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
> index 39da7698b09..4cc19239319 100644
> --- a/.gitlab-ci.d/buildtest-template.yml
> +++ b/.gitlab-ci.d/buildtest-template.yml
> @@ -63,6 +63,7 @@
> stage: test
> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG
> script:
> + - export RUST_BACKTRACE=1
> - source scripts/ci/gitlab-ci-section
> - section_start buildenv "Setting up to run tests"
> - scripts/git-submodule.sh update roms/SLOF
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-01-29 8:20 [PATCH] gitlab-ci: include full Rust backtraces in test runs Paolo Bonzini
2025-01-29 8:26 ` Thomas Huth
@ 2025-01-29 8:26 ` Philippe Mathieu-Daudé
2025-03-10 9:21 ` Peter Maydell
2 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-01-29 8:26 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: berrange, qemu-rust
On 29/1/25 09:20, Paolo Bonzini wrote:
Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitlab-ci.d/buildtest-template.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
> index 39da7698b09..4cc19239319 100644
> --- a/.gitlab-ci.d/buildtest-template.yml
> +++ b/.gitlab-ci.d/buildtest-template.yml
> @@ -63,6 +63,7 @@
> stage: test
> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG
> script:
> + - export RUST_BACKTRACE=1
> - source scripts/ci/gitlab-ci-section
> - section_start buildenv "Setting up to run tests"
> - scripts/git-submodule.sh update roms/SLOF
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-01-29 8:20 [PATCH] gitlab-ci: include full Rust backtraces in test runs Paolo Bonzini
2025-01-29 8:26 ` Thomas Huth
2025-01-29 8:26 ` Philippe Mathieu-Daudé
@ 2025-03-10 9:21 ` Peter Maydell
2025-03-10 9:25 ` Daniel P. Berrangé
2 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2025-03-10 9:21 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, berrange, qemu-rust
On Wed, 29 Jan 2025 at 08:21, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitlab-ci.d/buildtest-template.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
> index 39da7698b09..4cc19239319 100644
> --- a/.gitlab-ci.d/buildtest-template.yml
> +++ b/.gitlab-ci.d/buildtest-template.yml
> @@ -63,6 +63,7 @@
> stage: test
> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG
> script:
> + - export RUST_BACKTRACE=1
> - source scripts/ci/gitlab-ci-section
> - section_start buildenv "Setting up to run tests"
> - scripts/git-submodule.sh update roms/SLOF
> --
This will only add the rust backtraces when the tests
are run from the CI logs, not when you locally run
"make check" or similar. There's probably a better place
to put this...
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-03-10 9:21 ` Peter Maydell
@ 2025-03-10 9:25 ` Daniel P. Berrangé
2025-03-10 9:35 ` Peter Maydell
2025-03-10 9:40 ` Paolo Bonzini
0 siblings, 2 replies; 8+ messages in thread
From: Daniel P. Berrangé @ 2025-03-10 9:25 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, qemu-devel, qemu-rust
On Mon, Mar 10, 2025 at 09:21:37AM +0000, Peter Maydell wrote:
> On Wed, 29 Jan 2025 at 08:21, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > .gitlab-ci.d/buildtest-template.yml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
> > index 39da7698b09..4cc19239319 100644
> > --- a/.gitlab-ci.d/buildtest-template.yml
> > +++ b/.gitlab-ci.d/buildtest-template.yml
> > @@ -63,6 +63,7 @@
> > stage: test
> > image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG
> > script:
> > + - export RUST_BACKTRACE=1
> > - source scripts/ci/gitlab-ci-section
> > - section_start buildenv "Setting up to run tests"
> > - scripts/git-submodule.sh update roms/SLOF
> > --
>
> This will only add the rust backtraces when the tests
> are run from the CI logs, not when you locally run
> "make check" or similar. There's probably a better place
> to put this...
Meson's 'test()' command accepts env variables, but it'll be somewhat
tedious to add the same env to all case where we use test. Might want
to define a common 'testenv' set at the top level meson.build and then
reference it from every 'test()', unless meson has built-in support
for globally applied env vars that I'm missing.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-03-10 9:25 ` Daniel P. Berrangé
@ 2025-03-10 9:35 ` Peter Maydell
2025-03-10 9:40 ` Paolo Bonzini
1 sibling, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2025-03-10 9:35 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: Paolo Bonzini, qemu-devel, qemu-rust
On Mon, 10 Mar 2025 at 09:25, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, Mar 10, 2025 at 09:21:37AM +0000, Peter Maydell wrote:
> > On Wed, 29 Jan 2025 at 08:21, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > > .gitlab-ci.d/buildtest-template.yml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml
> > > index 39da7698b09..4cc19239319 100644
> > > --- a/.gitlab-ci.d/buildtest-template.yml
> > > +++ b/.gitlab-ci.d/buildtest-template.yml
> > > @@ -63,6 +63,7 @@
> > > stage: test
> > > image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG
> > > script:
> > > + - export RUST_BACKTRACE=1
> > > - source scripts/ci/gitlab-ci-section
> > > - section_start buildenv "Setting up to run tests"
> > > - scripts/git-submodule.sh update roms/SLOF
> > > --
> >
> > This will only add the rust backtraces when the tests
> > are run from the CI logs, not when you locally run
> > "make check" or similar. There's probably a better place
> > to put this...
>
> Meson's 'test()' command accepts env variables, but it'll be somewhat
> tedious to add the same env to all case where we use test. Might want
> to define a common 'testenv' set at the top level meson.build and then
> reference it from every 'test()', unless meson has built-in support
> for globally applied env vars that I'm missing.
Or we could set it in tests/Makefile.include :-)
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-03-10 9:25 ` Daniel P. Berrangé
2025-03-10 9:35 ` Peter Maydell
@ 2025-03-10 9:40 ` Paolo Bonzini
2025-03-10 10:31 ` Peter Maydell
1 sibling, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2025-03-10 9:40 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: Peter Maydell, qemu-devel, qemu-rust
On Mon, Mar 10, 2025 at 10:25 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > This will only add the rust backtraces when the tests
> > are run from the CI logs, not when you locally run
> > "make check" or similar. There's probably a better place
> > to put this...
>
> Meson's 'test()' command accepts env variables, but it'll be somewhat
> tedious to add the same env to all case where we use test. Might want
> to define a common 'testenv' set at the top level meson.build and then
> reference it from every 'test()', unless meson has built-in support
> for globally applied env vars that I'm missing.
It can be added to add_test_setup().
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
2025-03-10 9:40 ` Paolo Bonzini
@ 2025-03-10 10:31 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2025-03-10 10:31 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Daniel P. Berrangé, qemu-devel, qemu-rust
On Mon, 10 Mar 2025 at 09:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On Mon, Mar 10, 2025 at 10:25 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > This will only add the rust backtraces when the tests
> > > are run from the CI logs, not when you locally run
> > > "make check" or similar. There's probably a better place
> > > to put this...
> >
> > Meson's 'test()' command accepts env variables, but it'll be somewhat
> > tedious to add the same env to all case where we use test. Might want
> > to define a common 'testenv' set at the top level meson.build and then
> > reference it from every 'test()', unless meson has built-in support
> > for globally applied env vars that I'm missing.
>
> It can be added to add_test_setup().
Thanks -- I just sent a patch to do it that way:
https://patchew.org/QEMU/20250310102950.3752908-1-peter.maydell@linaro.org/
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-03-10 10:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-29 8:20 [PATCH] gitlab-ci: include full Rust backtraces in test runs Paolo Bonzini
2025-01-29 8:26 ` Thomas Huth
2025-01-29 8:26 ` Philippe Mathieu-Daudé
2025-03-10 9:21 ` Peter Maydell
2025-03-10 9:25 ` Daniel P. Berrangé
2025-03-10 9:35 ` Peter Maydell
2025-03-10 9:40 ` Paolo Bonzini
2025-03-10 10:31 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).