From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96690C87FC9 for ; Tue, 29 Jul 2025 14:19:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uglBK-00044K-1m; Tue, 29 Jul 2025 10:19:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uglBF-00042Q-6J for qemu-rust@nongnu.org; Tue, 29 Jul 2025 10:19:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uglBD-0002t9-45 for qemu-rust@nongnu.org; Tue, 29 Jul 2025 10:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753798779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f0M5pMeShAvl7P14FsQvrzgLM6UN5hkzxIUt6Am8+ck=; b=OISV4x99Q+0usmriBPtDEUA5ThmIP4s6b3fjcTU97980+saoQ4yIir0It7ufuVqr7Snx0c 4sbFALxY+bTbDuhfeQpQ7ZAKm62jmIzMKVkj8v0MUCr2DJfSg/S26EeuNpN3+z+o7ry5kq Hj0WHyrGkXedUnb9Is+lmOk9YTBd6lY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-pMFLPSp4NjqfPX6KIMKDaQ-1; Tue, 29 Jul 2025 10:19:38 -0400 X-MC-Unique: pMFLPSp4NjqfPX6KIMKDaQ-1 X-Mimecast-MFC-AGG-ID: pMFLPSp4NjqfPX6KIMKDaQ_1753798777 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3b7882c0992so1312945f8f.0 for ; Tue, 29 Jul 2025 07:19:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753798777; x=1754403577; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f0M5pMeShAvl7P14FsQvrzgLM6UN5hkzxIUt6Am8+ck=; b=WY3+8PnbEwrexCDUzJtj6z6tXD7ZO+2LCNW8YoxZJUaTLaosKg/YurOa9zHtA3I1Vy /8TVwbaNme9+1ZKXE4Y372XIGAtCSw/GQMfwZ93kscD7VD6Sef6YgGxwjEr9QwhcXazp vbxjH6YhsjoaI159ARdsKbywnipIYTiXYLlBbQTn9T5BTt/kULi08cwJzoId6T0zZbbR G4YSG603RfwjAz5aU+8d6J/oogIb5SCJRRqVENRw65GNHPrYW2b7VbdeJQQcHj5SKegO oOAyMDEcmhlVPzzF24PRDkPpd+SCrlyQIuNoVSbjKEPLZvWJXpbbrYU58J5gE6c5GNpV RV4Q== X-Gm-Message-State: AOJu0YwDTL1pbeKUfBwrePuG5BDl0P34mRGnClLOLDNrhageRcB8XAu8 Grq043uPgQGXfJucUjSQkIebX/IyMelweNRtvjkS/TOHuZoqPNJaXaa0V6AkG8S+ynCA1Ul/Gqm HxQ0ZD99fQ1tIxbTUK3LRIFHfVbB7dye3Hs8JBnkrOqWLwNctywtZYN4= X-Gm-Gg: ASbGncuL/gEZPrJhPLxsVPlaEJeiie1MYiXCJy8x2br6IrurIFvpmPUMsYtWecnnIMk LZJqj2C+JBSWXqQu0EMYXtsb0rAPlHqIRh+ILsI/B/aZzKjIa2MB2SDRfo1K7wqbV1ME2Lr9PQI KKLk3VHgZ1cpqwB046qRjjAwzslLGyISZJQSxhPzxlgr7XKIALSui5MApCtUXtTRybhv/9MdyDA rkUHRTDim/urZRKXeIIge2uxxPDW7zeeyC3UGHyEV/f1FbKIZUEgjmySl3h7z8P34APd2dFp4eU 6Pp55iiG9eoqH4zNqJnB8e7vqsaLEhFKru1LWgnmkzD4 X-Received: by 2002:a05:6000:25c8:b0:3b7:75d9:5ee5 with SMTP id ffacd0b85a97d-3b776645f69mr10213759f8f.29.1753798776864; Tue, 29 Jul 2025 07:19:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEB9kWsV5hSeg8ZHoKaItiO91vXjFS1ORpLj2JA0USYGK45MG6Q6sSS6ymJxDQoOgOgtL+Dkg== X-Received: by 2002:a05:6000:25c8:b0:3b7:75d9:5ee5 with SMTP id ffacd0b85a97d-3b776645f69mr10213735f8f.29.1753798776265; Tue, 29 Jul 2025 07:19:36 -0700 (PDT) Received: from [192.168.10.81] ([151.95.154.122]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3b793519f3asm1495981f8f.36.2025.07.29.07.19.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Jul 2025 07:19:35 -0700 (PDT) Message-ID: <2fbf7b01-981a-4c12-a972-3c008056a3ad@redhat.com> Date: Tue, 29 Jul 2025 16:19:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rust: declare self as qemu_api for proc-macros To: Manos Pitsidianakis , qemu-devel@nongnu.org Cc: qemu-rust@nongnu.org References: <20250728-self-as-qemu_api-v1-1-001c339cccc8@linaro.org> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20250728-self-as-qemu_api-v1-1-001c339cccc8@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BJ-M5zeVeth6cWzdHpRrkKX1eXBmGJFsww3fm5miWBY_1753798777 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On 7/28/25 13:48, Manos Pitsidianakis wrote: > Fix an outstanding TODO. > > Declaring `extern crate self as qemu_api` allows use of `qemu_api` > within the qemu_api crate; this allows the Wrapper derive macro and > future proc macros to be used interchangeably in the qemu_api crate and > other crates. This is not required currently and is only for > future-proofing. > > Signed-off-by: Manos Pitsidianakis I had no idea 'extern crate self' existed! Nice, I queued it because it's useful for the purpose of splitting the qemu_api crate. Paolo > --- > rust/qemu-api-macros/src/lib.rs | 14 ++++++-------- > rust/qemu-api/src/lib.rs | 3 +++ > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/rust/qemu-api-macros/src/lib.rs b/rust/qemu-api-macros/src/lib.rs > index b525d89c09e496a1f7f5582dc6d994e318f62bca..e01ac26cf3dd5a1b06ce095ef32b27a67e0def19 100644 > --- a/rust/qemu-api-macros/src/lib.rs > +++ b/rust/qemu-api-macros/src/lib.rs > @@ -115,23 +115,21 @@ fn derive_opaque_or_error(input: DeriveInput) -> Result let field = &get_unnamed_field(&input, "#[derive(Wrapper)]")?; > let typ = &field.ty; > > - // TODO: how to add "::qemu_api"? For now, this is only used in the > - // qemu_api crate so it's not a problem. > Ok(quote! { > - unsafe impl crate::cell::Wrapper for #name { > - type Wrapped = <#typ as crate::cell::Wrapper>::Wrapped; > + unsafe impl ::qemu_api::cell::Wrapper for #name { > + type Wrapped = <#typ as ::qemu_api::cell::Wrapper>::Wrapped; > } > impl #name { > - pub unsafe fn from_raw<'a>(ptr: *mut ::Wrapped) -> &'a Self { > + pub unsafe fn from_raw<'a>(ptr: *mut ::Wrapped) -> &'a Self { > let ptr = ::std::ptr::NonNull::new(ptr).unwrap().cast::(); > unsafe { ptr.as_ref() } > } > > - pub const fn as_mut_ptr(&self) -> *mut ::Wrapped { > + pub const fn as_mut_ptr(&self) -> *mut ::Wrapped { > self.0.as_mut_ptr() > } > > - pub const fn as_ptr(&self) -> *const ::Wrapped { > + pub const fn as_ptr(&self) -> *const ::Wrapped { > self.0.as_ptr() > } > > @@ -139,7 +137,7 @@ pub const fn as_void_ptr(&self) -> *mut ::core::ffi::c_void { > self.0.as_void_ptr() > } > > - pub const fn raw_get(slot: *mut Self) -> *mut ::Wrapped { > + pub const fn raw_get(slot: *mut Self) -> *mut ::Wrapped { > slot.cast() > } > } > diff --git a/rust/qemu-api/src/lib.rs b/rust/qemu-api/src/lib.rs > index 86dcd8ef17a9ecd040742a99e4b0421e19ec88f6..44d995cfdb990e0d17e7216cf4d1f04a5a980a1f 100644 > --- a/rust/qemu-api/src/lib.rs > +++ b/rust/qemu-api/src/lib.rs > @@ -32,6 +32,9 @@ > pub mod vmstate; > pub mod zeroable; > > +// Allow proc-macros to refer to `::qemu_api` inside the `qemu_api` crate (this crate). > +extern crate self as qemu_api; > + > use std::{ > alloc::{GlobalAlloc, Layout}, > ffi::c_void, > > --- > base-commit: c017386f28c03a03b8f14444f8671d3d8f7180fe > change-id: 20250728-self-as-qemu_api-de5ad829a034 > > -- > γαῖα πυρί μιχθήτω > > >