From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D39BCA0FED for ; Wed, 27 Aug 2025 09:49:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1urCmU-0004sL-I2; Wed, 27 Aug 2025 05:49:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urCmM-0004r9-2N for qemu-rust@nongnu.org; Wed, 27 Aug 2025 05:49:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urCmF-0003Ud-VS for qemu-rust@nongnu.org; Wed, 27 Aug 2025 05:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756288148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DzPJLfP9VECufLuWOQ8dGHcHfP7LJTlDeegqWyXFcI8=; b=bZ00PQpZovxkWcXYue9BNo6JrVBZpUe3UCIkDumK5iP5+yWSbyLcjgZuUEtCQm+04lJcVH NOFXaTWpocBe8100hFnttr/VsLcrNusYjHlSCNZmlUWujKcjx1v7denfMQCoLxlceKsDB7 gIbTrcZlnIXWtlzc2sto5UrgQ15kYBY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-Ejr8wfD6MUe7GEQCDgzO5g-1; Wed, 27 Aug 2025 05:49:06 -0400 X-MC-Unique: Ejr8wfD6MUe7GEQCDgzO5g-1 X-Mimecast-MFC-AGG-ID: Ejr8wfD6MUe7GEQCDgzO5g_1756288145 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3c79f0a57ddso2253625f8f.1 for ; Wed, 27 Aug 2025 02:49:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756288145; x=1756892945; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DzPJLfP9VECufLuWOQ8dGHcHfP7LJTlDeegqWyXFcI8=; b=VSwytkO6Ud+YAI96ooQpoURdMkABYunzUtts9yuDHTcFvem1VBo8GA6SHm+zuffQ1P ybII13NeRfGX8PITIdDSBhQXHmFTgN0xbXV2gNFfu021/ozvbjQeY+guVX9VYUJwRppG WwXZS614cOl3boV4tNXanPOplvt54+dduFVbAInBxOxQ1s1JHYgg93igOG2kaFUA2RlR h4vSf5bFnJpnj7Q9qiu4Y1elUZgY+PvAYcHHz9eL804aoVNNA0yskPi229kW2BiJNZ3e kefYz3t1UzXaBRe113VYy421gY+TLa5mbp0O0BikgHCPbvpGs4x8+diEZqwbTXCOKCvA zfJw== X-Forwarded-Encrypted: i=1; AJvYcCVpNK0fOVgOkxPFkdED8uFxg8w3NiJNWhqJ0Fp/g806yiRJ4KnYh4mKr/YJRInHMyguVXUeVEBi1cM=@nongnu.org X-Gm-Message-State: AOJu0YzXvCpZT4o6k9w8GXxLjyfV3sdj8c3pByqMQ5f18gBapxka5BnB tK8x9lvhv5CsbEfIKpClHnSazFKqclJIMDYCalJnqHmqNMML2hJYteKo0g1J5gOohXTL8JRohMj FmGRcHr5giC8iJyB8OkVAnC/s4xyuJ2Sgw7viSoNUM3OikYXiEoWYLB0= X-Gm-Gg: ASbGncucAHeKVh352ZUNWSRyb7dCinVYQJo05RWmCdco3sneS7QjEcKqGfXpBGDoqnr in2nBY793kJ+/cGh2x9Q8DxEFTMrrY/hdaUU2lnUggty/7hhEi8dPANH9j9htyz3B2U9w/tj1P4 MTt4msxxbTmR6COt5DGl84vE8zaKLYNYVOYSwN16NgkQE+skW4uudBnuChcnQ2dHrie7XyRVW8P UuU5reM0DdU6kngQGSUMjMpYrqXO0mA9Lt7qndG9P64FPBlg42hvnBG5kjfr1IOv18Y4aRWBBgF vLMwpc+BYeSkdB81/0weChOW9/ruk1do3aB/3iQrh/ysSUcQmAgRcdwPKlrqvZ7yydOGaW6OqU4 XQe66vfnKLBCTNO8vrck7IpgppS9xiUIXC0yqLMDGrek= X-Received: by 2002:a5d:5887:0:b0:3b8:dabe:bd8b with SMTP id ffacd0b85a97d-3c5db2dce81mr14047948f8f.27.1756288144747; Wed, 27 Aug 2025 02:49:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhP4j4C4I+q5CKbWpfC3LLGYNXjDeqvhKlGQpKICiMGFuVwzPDHHmEMu0VYLc2H/d15WQnTg== X-Received: by 2002:a5d:5887:0:b0:3b8:dabe:bd8b with SMTP id ffacd0b85a97d-3c5db2dce81mr14047914f8f.27.1756288144209; Wed, 27 Aug 2025 02:49:04 -0700 (PDT) Received: from [192.168.10.27] ([151.95.56.250]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3cd2e01dd9dsm773837f8f.60.2025.08.27.02.49.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Aug 2025 02:49:03 -0700 (PDT) Message-ID: <599c6937-9fc3-4625-ab8e-08ef02d527ff@redhat.com> Date: Wed, 27 Aug 2025 11:49:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 10/18] rust: split "qom" crate To: =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Zhao Liu Cc: qemu-devel@nongnu.org, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-rust@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Manos Pitsidianakis References: <20250826140449.4190022-1-marcandre.lureau@redhat.com> <20250826140449.4190022-11-marcandre.lureau@redhat.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: waKvCFIBT_6TMdMJY1yyzSck7-nZ9Yo_wZh9OzX98Fk_1756288145 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On 8/27/25 10:57, Marc-André Lureau wrote: > Hi > > On Wed, Aug 27, 2025 at 10:33 AM Zhao Liu > wrote: > > > diff --git a/rust/hw/char/pl011/src/device.rs > b/rust/hw/char/pl011/src/device.rs > > index 7cffb894a8..a3bcd1297a 100644 > > --- a/rust/hw/char/pl011/src/device.rs > > +++ b/rust/hw/char/pl011/src/device.rs > > @@ -21,10 +21,13 @@ > >      memory::{hwaddr, MemoryRegion, MemoryRegionOps, > MemoryRegionOpsBuilder}, > >      prelude::*, > >      qdev::{Clock, ClockEvent, DeviceImpl, DeviceState, Property, > ResetType, ResettablePhasesImpl}, > > -    qom::{ObjectImpl, Owned, ParentField, ParentInit}, > >      sysbus::{SysBusDevice, SysBusDeviceImpl}, > >      vmstate_clock, > >  }; > > +use qom::{ > > +    qom_isa, IsA, Object, ObjectClassMethods, ObjectDeref, > ObjectImpl, ObjectMethods, ObjectType, > > +    Owned, ParentField, ParentInit, > > +}; > > These QOM parts are frequently used and very common. at least for qom, > I think prelude would help a lot. > > > ack > > A qom prelude could help reduce the changes in other parts (pl011/ > hpet/memory...). > > > diff --git a/rust/qom/meson.build b/rust/qom/meson.build > > new file mode 100644 > > index 0000000000..6e95d75fa0 > > --- /dev/null > > +++ b/rust/qom/meson.build > > @@ -0,0 +1,61 @@ > > +_qom_cfg = run_command(rustc_args, > > +  '--config-headers', config_host_h, '--features', > files('Cargo.toml'), > > +  capture: true, check: true).stdout().strip().splitlines() > > + > > +# TODO: Remove this comment when the clang/libclang mismatch > issue is solved. > > +# > > +# Rust bindings generation with `bindgen` might fail in some > cases where the > > +# detected `libclang` does not match the expected `clang` > version/target. In > > +# this case you must pass the path to `clang` and `libclang` to > your build > > +# command invocation using the environment variables CLANG_PATH and > > +# LIBCLANG_PATH > > +_qom_bindings_inc_rs = rust.bindgen( > > +  input: 'wrapper.h', > > +  dependencies: common_ss.all_dependencies(), > > +  output: 'bindings.inc.rs ', > > There're many binding files with the same name. What about adding a > prefix > like "qom-bindings" to distinguish it? This can help search and locate > specific binding file. > > > they are already under different directories :) > > > > +  include_directories: bindings_incdir, > > +  bindgen_version: ['>=0.60.0'], > > +  args: bindgen_args_common, > > +) > > ... > > > diff --git a/rust/qom/tests/tests.rs b/rust/ > qom/tests/tests.rs > > new file mode 100644 > > index 0000000000..49f1cbecf5 > > --- /dev/null > > +++ b/rust/qom/tests/tests.rs > > @@ -0,0 +1,47 @@ > > +use std::{ffi::CStr, sync::LazyLock}; > > LazyLock is useful, but it became stable since v1.80. So if Paolo > decide pick this series after v1.83 support, it's fine. yes, you all can assume 1.83. Paolo