Re: [PATCH v2] rust: bindings: allow any number of params

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 15/7/25 08:15, Michael S. Tsirkin wrote:
> We are going to be adding more parameters, and this makes
> rust unhappy:
>      Functions with lots of parameters are considered bad style and reduce
>      readability (“what does the 5th parameter mean?”). Consider grouping
>      some parameters into a new type.
> 
> Specifically:
> 
> error: this function has too many arguments (8/7)
>      --> /builds/mstredhat/qemu/build/rust/qemu-api/rust-qemu-api-tests.p/structured/bindings.inc.rs:3840:5
>       |
> 3840 | /     pub fn new_bitfield_1(
> 3841 | |         secure: std::os::raw::c_uint,
> 3842 | |         space: std::os::raw::c_uint,
> 3843 | |         user: std::os::raw::c_uint,
> ...    |
> 3848 | |         address_type: std::os::raw::c_uint,
> 3849 | |     ) -> __BindgenBitfieldUnit<[u8; 4usize]> {
>       | |____________________________________________^
>       |
>       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
>       = note: `-D clippy::too-many-arguments` implied by `-D warnings`
>       = help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   rust/qemu-api/src/bindings.rs | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>