From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8331EB5967 for ; Wed, 11 Feb 2026 05:57:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vq3DX-0001Tc-9u; Wed, 11 Feb 2026 00:56:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vq3DW-0001TE-5E for qemu-rust@nongnu.org; Wed, 11 Feb 2026 00:56:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vq3DT-0003Qo-8B for qemu-rust@nongnu.org; Wed, 11 Feb 2026 00:56:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770789406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sfvh974GGTYCys12cTpMbulPNsloShDMG9sMHy5Vrrg=; b=F6TJKZopIoFCqVK1g9nWGC0Tz7Sz7l0gKhucMjbTHZITZFnHskfED1C47z0iIMcrtRmkqX eNRFmt3b+hY2xqd6hKy3aMge0D/BlGeXHrqx4xBwU/0ViAGFhTndR4CWL/bWXXNzrCKgpP h7hupqp7T12AcVLIcJ2EcqqqGHM76eo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-KwZcjdRyPm2oqpmJEXMdig-1; Wed, 11 Feb 2026 00:56:43 -0500 X-MC-Unique: KwZcjdRyPm2oqpmJEXMdig-1 X-Mimecast-MFC-AGG-ID: KwZcjdRyPm2oqpmJEXMdig_1770789401 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BDF711955F0E; Wed, 11 Feb 2026 05:56:40 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.15]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 071B91800464; Wed, 11 Feb 2026 05:56:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8F69121E692D; Wed, 11 Feb 2026 06:56:37 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Manos Pitsidianakis , Hanna Reitz , Gerd Hoffmann , Paolo Bonzini , Christian Schoenebeck , "Dr. David Alan Gilbert" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , devel@lists.libvirt.org, qemu-block@nongnu.org, qemu-rust@nongnu.org, Stefan Weil , Kevin Wolf , Richard Henderson Subject: Re: [PATCH v5 05/24] util: expose qemu_thread_set_name In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Tue, 10 Feb 2026 17:13:05 +0000") References: <20260108170338.2693853-1-berrange@redhat.com> <20260108170338.2693853-6-berrange@redhat.com> <87cy3dc1pl.fsf@pond.sub.org> Date: Wed, 11 Feb 2026 06:56:37 +0100 Message-ID: <878qcz4ycq.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: O4lx2rEnqJZv3F65j9CQ8fQocmi48aYMEfzr9hR2Xc0_1770789401 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Tue, Jan 13, 2026 at 10:16:06AM +0100, Markus Armbruster wrote: >> Daniel P. Berrang=C3=A9 writes: >>=20 >> > The ability to set the thread name needs to be used in a number >> > of places, so expose the current impls as public methods. >> > >> > Reviewed-by: Richard Henderson >> > Reviewed-by: Dr. David Alan Gilbert >> > Reviewed-by: Philippe Mathieu-Daud=C3=A9 >> > Signed-off-by: Daniel P. Berrang=C3=A9 [...] >> This delays setting the thread name until the thread runs. Fine, I >> guess, but I'd mention it in the commit message. > > Returning to this, the change is arguably /not/ delaying setting the > thread name, but in fact fixing a race condition when settnig the > thread name. > > This existing 'set_thread_description' call is taking place in the > parent thread, and at this point in the time the child thread has > potentially already been scheduled to run. So if the parent thread > was unscheduled, it is possible the child was running without having > it name set. This change eliminates that race. > > This distinction is important enough that I think I'll move this > specific change out into its own self-contained commit. Makes sense, thanks! [...]