From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92495E9A048 for ; Thu, 19 Feb 2026 10:15:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vt13s-0008Ho-G5; Thu, 19 Feb 2026 05:15:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vt13p-0008H0-QX for qemu-rust@nongnu.org; Thu, 19 Feb 2026 05:15:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vt13n-0007y1-Rh for qemu-rust@nongnu.org; Thu, 19 Feb 2026 05:15:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771496102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x62ZUzO8Kb3Te3uzAc93HO94tbcv+cSFLkmPd/ZgrJU=; b=Rr+BveOQWNivgIqjxjg6/dAXevvaopgQkxFFVLYgd2taVz00Gr51zaZH9Bj0N9FPg6NP6j MXxjZIdHpTgfT8FyUhFD+K56tRv1mf9ENHwrpac8zLEVzxH9q+EnUBZU2q2gRCYjVyd5VN DVhAkZ+18KMXiu35AweD9AISNJyuH3U= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-GuITgzevPP6yBNNLxXJpKw-1; Thu, 19 Feb 2026 05:14:59 -0500 X-MC-Unique: GuITgzevPP6yBNNLxXJpKw-1 X-Mimecast-MFC-AGG-ID: GuITgzevPP6yBNNLxXJpKw_1771496097 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A2081956094; Thu, 19 Feb 2026 10:14:57 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.14]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9BA619560A7; Thu, 19 Feb 2026 10:14:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5A64521E692D; Thu, 19 Feb 2026 11:14:54 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Manos Pitsidianakis , Stefan Weil , "Dr. David Alan Gilbert" , Pierrick Bouvier , devel@lists.libvirt.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr?= =?utf-8?Q?=C3=A9?= Lureau , Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org, qemu-rust@nongnu.org, Paolo Bonzini , Gerd Hoffmann , Christian Schoenebeck , Richard Henderson Subject: Re: [PATCH v6 26/27] util: add support for formatting thread info in messages In-Reply-To: <20260211152508.732487-27-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Wed, 11 Feb 2026 15:25:07 +0000") References: <20260211152508.732487-1-berrange@redhat.com> <20260211152508.732487-27-berrange@redhat.com> Date: Thu, 19 Feb 2026 11:14:54 +0100 Message-ID: <87ecmh3uqp.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: GtbHoS6L3SkvLmXu_13pyIOEoMXHA4PbCgfxQEXgqvo_1771496097 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_FAKE_RF=0.754, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > The message context is now extended to be able to include the > thread ID and thread name, after the program name. On Linux > the thread ID will match the process TID visible in /proc, > while on other platforms it will merely be an integer repr > of the system thread object address/ID. > > This changes the output for both error_report and qemu_log, > when running under the system emulators or the QEMU storage > daemon. Yes: $ qemu-system-x86_64 -object tls-creds-x509,id=3Dt0 qemu-system-x86_64: (1116063:main): Missing 'dir' property value I do not like this change. The part in (parenthesis) is gobbledygook for non-developers. I feel it should be off by default. Making it on by default for log message (as shown below) is fine. > Other programs omit the thread information since > they are largely single threaded, though potentially it > would be useful to enable in all of them, given that the RCU > thread will always get spawned by a constructor function. > > Before: > > # qemu-system-x86_64 -object tls-creds-x509,id=3Dt0,dir=3Dfish -d 'trac= e:qcrypto*' > qemu-system-x86_64: qcrypto_tls_creds_x509_load TLS creds x509 load cre= ds=3D0x560db818e080 dir=3Dfish > qemu-system-x86_64: qcrypto_tls_creds_get_path TLS creds path creds=3D0= x560db818e080 filename=3Dca-cert.pem path=3D > qemu-system-x86_64: Unable to access credentials fish/ca-cert.pem: No s= uch file or directory > > After: > > # qemu-system-x86_64 -object tls-creds-x509,id=3Dt0,dir=3Dfish -d 'trac= e:qcrypto*' > qemu-system-x86_64: (772366:main): qcrypto_tls_creds_x509_load TLS cred= s x509 load creds=3D0x560db818e080 dir=3Dfish > qemu-system-x86_64: (772366:main): qcrypto_tls_creds_get_path TLS creds= path creds=3D0x560db818e080 filename=3Dca-cert.pem path=3D > qemu-system-x86_64: (772366:main): Unable to access credentials fish/ca= -cert.pem: No such file or directory > > The '-msg thread-info=3Don|off' argument is introduced to allow this > new default output to be supressed if desired. > > Reviewed-by: Richard Henderson > Signed-off-by: Daniel P. Berrang=C3=A9