From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Hanna Reitz" <hreitz@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
devel@lists.libvirt.org, qemu-block@nongnu.org,
qemu-rust@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
"Kevin Wolf" <kwolf@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v5 01/24] qemu-options: remove extraneous [] around arg values
Date: Tue, 13 Jan 2026 08:47:23 +0100 [thread overview]
Message-ID: <87ldi2ar90.fsf@pond.sub.org> (raw)
In-Reply-To: <20260108170338.2693853-2-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Thu, 8 Jan 2026 17:03:15 +0000")
Daniel P. Berrangé <berrange@redhat.com> writes:
> There are quite a few inappropriate uses of [...] around argument
> values. The [] are intended to indicate optionality, but in some
> cases it is used to wrap a set of enum values. In other cases it
> is being used to show the value is entirely optional, which was
> common behaviour for boolean values in the past. QEMU has deprecated
> short-form boolean options for quite a while though, and we should
> thus not advertize this possibility in the docs.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2026-01-13 7:48 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 17:03 [PATCH v5 00/24] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 01/24] qemu-options: remove extraneous [] around arg values Daniel P. Berrangé
2026-01-13 7:47 ` Markus Armbruster [this message]
2026-01-08 17:03 ` [PATCH v5 02/24] include: define constant for early constructor priority Daniel P. Berrangé
2026-01-09 11:39 ` Paolo Bonzini
2026-01-09 11:46 ` Daniel P. Berrangé
2026-01-09 12:09 ` Paolo Bonzini
2026-01-13 9:04 ` Markus Armbruster
2026-01-13 9:32 ` Paolo Bonzini
2026-01-14 11:20 ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 03/24] monitor: initialize global data from a constructor Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 04/24] system: unconditionally enable thread naming Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 05/24] util: expose qemu_thread_set_name Daniel P. Berrangé
2026-01-13 9:16 ` Markus Armbruster
2026-01-13 10:41 ` Daniel P. Berrangé
2026-02-10 17:13 ` Daniel P. Berrangé
2026-02-11 5:56 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 06/24] audio: make jackaudio use qemu_thread_set_name Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 07/24] util: set the name for the 'main' thread Daniel P. Berrangé
2026-01-09 11:45 ` Paolo Bonzini
2026-01-09 11:52 ` Daniel P. Berrangé
2026-01-09 12:04 ` Paolo Bonzini
2026-01-08 17:03 ` [PATCH v5 08/24] util: add API to fetch the current thread name Daniel P. Berrangé
2026-01-09 11:49 ` Paolo Bonzini
2026-01-09 11:56 ` Daniel P. Berrangé
2026-01-09 12:11 ` Paolo Bonzini
2026-01-13 9:27 ` Markus Armbruster
2026-01-13 10:00 ` Daniel P. Berrangé
2026-01-13 13:00 ` Markus Armbruster
2026-01-13 15:49 ` Paolo Bonzini
2026-01-14 11:28 ` Daniel P. Berrangé
2026-01-14 11:27 ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 09/24] util: introduce some API docs for logging APIs Daniel P. Berrangé
2026-01-13 9:59 ` Markus Armbruster
2026-01-13 10:49 ` Daniel P. Berrangé
2026-01-13 10:52 ` Daniel P. Berrangé
2026-01-13 13:04 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 10/24] util: avoid repeated prefix on incremental qemu_log calls Daniel P. Berrangé
2026-01-13 10:19 ` Markus Armbruster
2026-01-13 11:56 ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 11/24] ui/vnc: remove use of error_printf_unless_qmp() Daniel P. Berrangé
2026-01-13 13:11 ` Markus Armbruster
2026-01-13 14:44 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 12/24] monitor: remove redundant error_[v]printf_unless_qmp Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 13/24] monitor: refactor error_vprintf() Daniel P. Berrangé
2026-01-13 13:17 ` Markus Armbruster
2026-01-14 11:34 ` Markus Armbruster
2026-01-14 12:01 ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 14/24] monitor: move error_vprintf back to error-report.c Daniel P. Berrangé
2026-01-13 13:38 ` Markus Armbruster
2026-01-14 12:09 ` Daniel P. Berrangé
2026-01-14 13:13 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 15/24] monitor: introduce monitor_cur_is_hmp() helper Daniel P. Berrangé
2026-01-13 14:57 ` Markus Armbruster
2026-01-14 12:46 ` Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 16/24] util: don't skip error prefixes when QMP is active Daniel P. Berrangé
2026-01-11 22:25 ` Richard Henderson
2026-01-13 15:19 ` Markus Armbruster
2026-01-14 12:53 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 17/24] util: fix interleaving of error & trace output Daniel P. Berrangé
2026-01-11 22:28 ` Richard Henderson
2026-01-14 13:00 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 18/24] util: fix interleaving of error prefixes Daniel P. Berrangé
2026-01-14 14:00 ` Markus Armbruster
2026-01-08 17:03 ` [PATCH v5 19/24] util: introduce common helper for error-report & log code Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 20/24] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 21/24] util: add support for formatting a workload name in messages Daniel P. Berrangé
2026-01-08 17:03 ` [PATCH v5 22/24] util: add support for formatting a program " Daniel P. Berrangé
2026-01-11 22:31 ` Richard Henderson
2026-01-08 17:03 ` [PATCH v5 23/24] util: add support for formatting thread info " Daniel P. Berrangé
2026-01-11 22:32 ` Richard Henderson
2026-01-08 17:03 ` [PATCH v5 24/24] util: add brackets around guest name in message context Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldi2ar90.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=devel@lists.libvirt.org \
--cc=hreitz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox