From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 302C4E9A047 for ; Wed, 18 Feb 2026 12:12:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsgPt-0004iZ-1s; Wed, 18 Feb 2026 07:12:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsgPp-0004i5-3S for qemu-rust@nongnu.org; Wed, 18 Feb 2026 07:12:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsgPn-0004F7-BD for qemu-rust@nongnu.org; Wed, 18 Feb 2026 07:12:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771416742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrigOBYiXuhVxecp2GY0LaW6xQojf+sPiDEWmX86LEE=; b=Wu1VRX/J7XevCqM6/4Qr/cqK7CaBYXldsxsXJA2BDUiL7aSl+bPodH/L6z0Ga1LwFbVfLF RjhwSe5FLNBAIKvFHo9wU2bzhmuk5rQbM5iHrbckNtbpBWefbc9BW1bp2uUxwUA+kamczB 5G5vHBslNsZqdjbFcNJEhfbLUO8YGNo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-_zbJmncENgyx2CBl6rBbDw-1; Wed, 18 Feb 2026 07:12:19 -0500 X-MC-Unique: _zbJmncENgyx2CBl6rBbDw-1 X-Mimecast-MFC-AGG-ID: _zbJmncENgyx2CBl6rBbDw_1771416737 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 33FDA19560B2; Wed, 18 Feb 2026 12:12:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.14]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA83E1800352; Wed, 18 Feb 2026 12:12:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6A12121E692D; Wed, 18 Feb 2026 13:12:14 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Manos Pitsidianakis , Stefan Weil , "Dr. David Alan Gilbert" , Pierrick Bouvier , devel@lists.libvirt.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr?= =?utf-8?Q?=C3=A9?= Lureau , Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org, qemu-rust@nongnu.org, Paolo Bonzini , Gerd Hoffmann , Christian Schoenebeck , Richard Henderson Subject: Re: [PATCH v6 15/27] ui: remove redundant use of error_printf_unless_qmp() In-Reply-To: <20260211152508.732487-16-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Wed, 11 Feb 2026 15:24:56 +0000") References: <20260211152508.732487-1-berrange@redhat.com> <20260211152508.732487-16-berrange@redhat.com> Date: Wed, 18 Feb 2026 13:12:14 +0100 Message-ID: <87o6lmcktd.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: ECVW8ydAFFxU9JxyeB6noiG7wfTWcEJaOMuYLWmHb-M_1771416737 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_FAKE_RF=0.754, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > The vnc_display_print_local_addr() method is intended to print the VNC > listening address on the console at startup, so the user can see the > auto-chosen port address when using the 'to=3D' flag. This is only called > by vnc_display_open() which is in the QEMU startup callpath. The check > for not being in QMP is thus redundant and can be removed. > > Signed-off-by: Daniel P. Berrang=C3=A9 > --- > ui/vnc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 833e0e2e68..fe020dcc4c 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3578,9 +3578,9 @@ static void vnc_display_print_local_addr(VncDisplay= *vd) > qapi_free_SocketAddress(addr); > return; > } > - error_printf_unless_qmp("VNC server running on %s:%s\n", > - addr->u.inet.host, > - addr->u.inet.port); > + error_printf("VNC server running on %s:%s\n", > + addr->u.inet.host, > + addr->u.inet.port); > qapi_free_SocketAddress(addr); > } Reviewed-by: Markus Armbruster Spotted in review: vnc_display_open() could be static. Observation, not a demand.