Re: [PATCH v2 00/16] rust: QObject and QAPI bindings

[Markus Armbruster <armbru@redhat.com>]

Paolo Bonzini <pbonzini@redhat.com> writes:

> This adds two related parts of the Rust bindings:

[...]

>  docs/devel/rust.rst                           |   1 +
>  meson.build                                   |   4 +-
>  include/qobject/qobject.h                     |   5 +-
>  rust/util/wrapper.h                           |   8 +
>  qapi/meson.build                              |   9 +
>  rust/Cargo.lock                               |   2 +
>  rust/Cargo.toml                               |   2 +
>  rust/meson.build                              |   4 +
>  rust/tests/meson.build                        |  21 +-
>  rust/tests/tests/integration.rs               |   2 +
>  rust/tests/tests/qapi.rs                      | 444 +++++++++++++
>  rust/util/Cargo.toml                          |   2 +
>  rust/util/meson.build                         |  30 +-
>  rust/util/src/lib.rs                          |   4 +
>  rust/util/src/qobject/deserialize.rs          | 134 ++++
>  rust/util/src/qobject/deserializer.rs         | 371 +++++++++++

Are you sure having two source filenames differ in just one character is
a good idea?

>  rust/util/src/qobject/error.rs                |  58 ++
>  rust/util/src/qobject/mod.rs                  | 383 ++++++++++++
>  rust/util/src/qobject/serialize.rs            |  59 ++
>  rust/util/src/qobject/serializer.rs           | 585 ++++++++++++++++++

Likewise.

These caused a bit of friction in review already...

[...]