From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-rust@nongnu.org
Subject: Re: [PATCH 2/2] rust: pl011: Really use RX FIFO depth
Date: Thu, 8 May 2025 13:15:48 +0200 [thread overview]
Message-ID: <90356173-31a1-48f7-9eb8-7a9068b167bf@linaro.org> (raw)
In-Reply-To: <20250508082943.446512-3-pbonzini@redhat.com>
On 8/5/25 10:29, Paolo Bonzini wrote:
> While we model a 16-elements RX FIFO since the PL011 model was
> introduced in commit cdbdb648b7c ("ARM Versatile Platform Baseboard
> emulation"), we only read 1 char at a time!
>
This comment ...
> Have the IOCanReadHandler handler return how many elements are
> available, and use that in the IOReadHandler handler.
... is not relevant, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> docs/devel/rust.rst | 2 +-
> rust/hw/char/pl011/src/device.rs | 14 +++++++-------
> 2 files changed, 8 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2025-05-08 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 8:29 [PATCH 0/2] rust: pl011: really use RX FIFO depth Paolo Bonzini
2025-05-08 8:29 ` [PATCH 1/2] rust: pl011: Rename RX FIFO methods Paolo Bonzini
2025-05-08 11:15 ` Philippe Mathieu-Daudé
2025-05-12 12:07 ` Peter Maydell
2025-05-08 8:29 ` [PATCH 2/2] rust: pl011: Really use RX FIFO depth Paolo Bonzini
2025-05-08 11:15 ` Philippe Mathieu-Daudé [this message]
2025-05-12 12:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90356173-31a1-48f7-9eb8-7a9068b167bf@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).