From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] subprojects: Update .gitignore for syn
Date: Tue, 30 Sep 2025 10:00:30 +0200 [thread overview]
Message-ID: <94426ef4-cbb6-4d3f-b0b0-e876e020110e@linaro.org> (raw)
In-Reply-To: <aNuSUHztLSchfd0o@intel.com>
On 30/9/25 10:18, Zhao Liu wrote:
> On Tue, Sep 30, 2025 at 09:50:24AM +0200, Philippe Mathieu-Daudé wrote:
>> Date: Tue, 30 Sep 2025 09:50:24 +0200
>> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Subject: Re: [PATCH] subprojects: Update .gitignore for syn
>>
>> On 30/9/25 09:53, Zhao Liu wrote:
>>> The commit a530a8d4ac39 missed to update syn version, this is because
>>> the code base of its v2 patch has fixed syn version, so that the fix for
>>> syn were lost during the rebase from v1 to v2.
>>>
>>> To rectify this mistake, update the syn version.
>>>
>>> Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
>>
>> IIUC the subprojects is in commit 9a6d6ae8afb, so:
>>
>> Fixes: 9a6d6ae8afb ("subprojects: update proc-macro2 and syn")
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> It's because the subject of a530a8d4ac39 mentioned to fix syn but it
> actually didn't :-).
Commit a530a8d4ac39 mentions "update", not "fix".
The 'Fixes:' tag is helpful for downstream forks, to cherry-pick
relevant commits.
>
> Fixes tag for 9a6d6ae8afb is also fine for me.
>
> Thanks!
>
> -Zhao
>
next prev parent reply other threads:[~2025-09-30 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 7:53 [PATCH] subprojects: Update .gitignore for syn Zhao Liu
2025-09-30 7:50 ` Philippe Mathieu-Daudé
2025-09-30 8:18 ` Zhao Liu
2025-09-30 8:00 ` Philippe Mathieu-Daudé [this message]
2025-09-30 8:08 ` Daniel P. Berrangé
2025-09-30 8:56 ` Zhao Liu
2025-09-30 9:22 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94426ef4-cbb6-4d3f-b0b0-e876e020110e@linaro.org \
--to=philmd@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).