From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3ACACAC599 for ; Tue, 16 Sep 2025 10:01:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uySUa-0003rZ-4Y; Tue, 16 Sep 2025 06:00:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uySUR-0003pY-CI for qemu-rust@nongnu.org; Tue, 16 Sep 2025 06:00:49 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uySUL-0007Ha-Uw for qemu-rust@nongnu.org; Tue, 16 Sep 2025 06:00:46 -0400 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-b0b6bf0097aso446136066b.1 for ; Tue, 16 Sep 2025 03:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758016839; x=1758621639; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iVls5VU3JEjGQ+uodD9dv4bGeKWVlOnJf9GTnykaWZM=; b=KclI4BsB66tCQsvGXjZ4c2SOU7xWFYpcZvnGFJkSH859eK6LaoZBPq0xN/4ZdR2Deq XasMe7VExtaZwZP3OsqdBIT2nOlHXKMnIzLxlk9zv2FyrIz5/lAZdCVNIhuVUiqLQxkQ o1t89s97Ah3OwehCa3Ny3WclaP7+o/V/30Yton3HLoJGcakSmOF9nruXB1kJy2ct9jhY coG0DM5+N7bzuv8P9tOmcEqgDYThcIN0oEEpMLF3b41lJOZMIZR9e/pi2ZBG87INJEX3 LyFqsfbfZhQE15wEJAJRGDy5ZfV9mqxUglrsmlRBkSRo8lFLmFmhjCy6EozNH8f3Hs+O DMnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758016839; x=1758621639; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iVls5VU3JEjGQ+uodD9dv4bGeKWVlOnJf9GTnykaWZM=; b=Tzbi3H6Pay+wtfwO3+JRIJ3Z0x8qKP3jxgigr/kD5Krw8oa84XpSJLoby844TsIQUW 4g9IfP/Yes5leV3Tzs8Jgu6vi6t7m/P9Kv49JmmspMdz9B2QyfJdKh7dzvfQ0sRwcAxZ VrJkZKK57i3eOMWK3MG97JVMbr0+Z7CphE7VyqOdlrYMllCeotM9KVOwdOsf0TFpKrlz QiiD+iZ0FlV+J1w4oHtuI/GRvtrwC36jK2fWjrXGnsOhLcjoM8gMMbYdF5kE2ZONLtn1 2YtVMlhDxFKbZcOeRIjhNB2TiUoK9R5Mx9STLc/HgMuw+o1TcJT5IfFWdFb8r/dI+6kj oTOg== X-Forwarded-Encrypted: i=1; AJvYcCV5RjJ5crbT31P+mF8fApWKzsdfxsoaMxwtODM0T6KYHuvDHBHuLD/DEDQ9g3ST2+bdUAvkO5saZHA=@nongnu.org X-Gm-Message-State: AOJu0YzeMjALr8DIvhyjip3FS7+p+x0r7BWufGJfjRURbLCz50NlUgKX ABdjJ06zONoM4t+nQoFXIF/Rqq1MEZ0JirG6j0C/4c1uhmROTAbt/UeiXfL4/w7WS7TQef2s8uV 5PjB2tZfY5FcUE+SWydQifDCz5yrCSaGfnMLYed7qUg== X-Gm-Gg: ASbGncszGWteug7PFS/ycnzodpgx/C2nbQNFdi+4zTULU0uu2sAWvVAeHE2Gd+1+5g/ VHRVowxKAVSIZXep3p4MDmDJHNlTp15wJUMFYZqFIC0oAtkrYkdaYREU7udRVoO+6oyHDNaRKmE z1eFPP710FqeXZw5KT2Izng6o/bkzxeHq+jXPElWfozyQSeKBjxDbhPqpkQ/heDH75lJalslKkc jCikDiELrzZGf2OvG4= X-Google-Smtp-Source: AGHT+IF6+aT70m+Rgv3kzi92PNuzebLr37fgQ+Z/3IN4loNvBdmXmGzo3aA+x/qK1dCLNh+GAlP7+EwzPS4ebf+nZ10= X-Received: by 2002:a17:906:ef07:b0:b07:b645:e5b8 with SMTP id a640c23a62f3a-b07c37de7d8mr1586149666b.30.1758016838892; Tue, 16 Sep 2025 03:00:38 -0700 (PDT) MIME-Version: 1.0 References: <20250916085557.2008344-1-zhao1.liu@intel.com> <20250916085557.2008344-4-zhao1.liu@intel.com> In-Reply-To: <20250916085557.2008344-4-zhao1.liu@intel.com> From: Manos Pitsidianakis Date: Tue, 16 Sep 2025 13:00:11 +0300 X-Gm-Features: AS18NWAEiqBTk3kGzK2OpWSWx3KG8AReMftuRm9Z-6XM-QJa3f1jqaPYFsHapgc Message-ID: Subject: Re: [PATCH 03/12] rust/qemu-macros: Fix Clippy's complaints about lambda parameter naming To: Zhao Liu Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-rust@nongnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On Tue, Sep 16, 2025 at 11:34=E2=80=AFAM Zhao Liu wro= te: > > error: `rename` shadows a previous, unrelated binding > --> qemu-macros/src/lib.rs:265:14 > | > 265 | |rename| -> Result { > | ^^^^^^ > | > note: previous binding is here > --> qemu-macros/src/lib.rs:245:30 > | > 245 | let DeviceProperty { rename, defval } =3D prop; > | ^^^^^^ > =3D help: for further information visit https://rust-lang.github.io/r= ust-clippy/master/index.html#shadow_unrelated > =3D note: requested on the command line with `-D clippy::shadow-unrel= ated` > > Rename the lambda parameter to "prop_rename" to fix the above clippy > error. > > Signed-off-by: Zhao Liu > --- Reviewed-by: Manos Pitsidianakis > rust/qemu-macros/src/lib.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rust/qemu-macros/src/lib.rs b/rust/qemu-macros/src/lib.rs > index 830b4326985b..ed4064d6e110 100644 > --- a/rust/qemu-macros/src/lib.rs > +++ b/rust/qemu-macros/src/lib.rs > @@ -262,8 +262,8 @@ macro_rules! str_to_c_str { > > let prop_name =3D rename.map_or_else( > || str_to_c_str!(field_name.to_string(), field_name.span()), > - |rename| -> Result { > - match rename { > + |prop_rename| -> Result { > + match prop_rename { > DevicePropertyName::CStr(cstr_lit) =3D> Ok(quote! { = #cstr_lit }), > DevicePropertyName::Str(str_lit) =3D> { > str_to_c_str!(str_lit.value(), str_lit.span()) > -- > 2.34.1 >