Re: [RFC 18/26] memory: Rename flatview_access_allowed() to memory_region_access_allowed()

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

On Thu, Aug 7, 2025 at 3:10 PM Zhao Liu <zhao1.liu@intel.com> wrote:
>
> flatview_access_allowed() accepts `MemoryRegion *mr` as an argument, so
> it's based on MemoryRegion and should be named as
> memory_region_access_allowed().
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>  system/physmem.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/system/physmem.c b/system/physmem.c
> index d2106d0ffa87..8aaaab4d3a74 100644
> --- a/system/physmem.c
> +++ b/system/physmem.c
> @@ -2921,7 +2921,7 @@ bool prepare_mmio_access(MemoryRegion *mr)
>  }
>
>  /**
> - * flatview_access_allowed
> + * memory_region_access_allowed
>   * @mr: #MemoryRegion to be accessed
>   * @attrs: memory transaction attributes
>   * @addr: address within that memory region
> @@ -2931,8 +2931,8 @@ bool prepare_mmio_access(MemoryRegion *mr)
>   *
>   * Returns: true if transaction is allowed, false if denied.
>   */
> -static bool flatview_access_allowed(MemoryRegion *mr, MemTxAttrs attrs,
> -                                    hwaddr addr, hwaddr len)
> +static bool memory_region_access_allowed(MemoryRegion *mr, MemTxAttrs attrs,
> +                                         hwaddr addr, hwaddr len)
>  {
>      if (likely(!attrs.memory)) {
>          return true;
> @@ -2952,7 +2952,7 @@ static MemTxResult flatview_write_continue_step(MemTxAttrs attrs,
>                                                  hwaddr len, hwaddr mr_addr,
>                                                  hwaddr *l, MemoryRegion *mr)
>  {
> -    if (!flatview_access_allowed(mr, attrs, mr_addr, *l)) {
> +    if (!memory_region_access_allowed(mr, attrs, mr_addr, *l)) {
>          return MEMTX_ACCESS_ERROR;
>      }
>
> @@ -3036,7 +3036,7 @@ static MemTxResult flatview_write(FlatView *fv, hwaddr addr, MemTxAttrs attrs,
>
>      l = len;
>      mr = flatview_translate(fv, addr, &mr_addr, &l, true, attrs);
> -    if (!flatview_access_allowed(mr, attrs, addr, len)) {
> +    if (!memory_region_access_allowed(mr, attrs, addr, len)) {
>          return MEMTX_ACCESS_ERROR;
>      }
>      return flatview_write_continue(fv, addr, attrs, buf, len,
> @@ -3048,7 +3048,7 @@ static MemTxResult flatview_read_continue_step(MemTxAttrs attrs, uint8_t *buf,
>                                                 hwaddr *l,
>                                                 MemoryRegion *mr)
>  {
> -    if (!flatview_access_allowed(mr, attrs, mr_addr, *l)) {
> +    if (!memory_region_access_allowed(mr, attrs, mr_addr, *l)) {
>          return MEMTX_ACCESS_ERROR;
>      }
>
> @@ -3127,7 +3127,7 @@ static MemTxResult flatview_read(FlatView *fv, hwaddr addr,
>
>      l = len;
>      mr = flatview_translate(fv, addr, &mr_addr, &l, false, attrs);
> -    if (!flatview_access_allowed(mr, attrs, addr, len)) {
> +    if (!memory_region_access_allowed(mr, attrs, addr, len)) {
>          return MEMTX_ACCESS_ERROR;
>      }
>      return flatview_read_continue(fv, addr, attrs, buf, len,
> --
> 2.34.1
>