From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] rust: build: remove "protocol: rust: from doctests
Date: Fri, 19 Sep 2025 13:40:30 +0300 [thread overview]
Message-ID: <CAAjaMXbk-sr4MAejAb8vkz_Yd1u+=k3cfnCWzeOvdWigHPiu0A@mail.gmail.com> (raw)
In-Reply-To: <20250919101642.121190-1-pbonzini@redhat.com>
On Fri, Sep 19, 2025 at 1:17 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> It is added already by rust.doctest.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
> rust/bql/meson.build | 1 -
> rust/common/meson.build | 1 -
> rust/migration/meson.build | 1 -
> rust/qom/meson.build | 1 -
> rust/util/meson.build | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/rust/bql/meson.build b/rust/bql/meson.build
> index 2e0d8a88ed3..305d7111897 100644
> --- a/rust/bql/meson.build
> +++ b/rust/bql/meson.build
> @@ -46,6 +46,5 @@ bql_rs = declare_dependency(link_with: [_bql_rs],
> # in a separate suite that is run by the "build" CI jobs rather than "check".
> rust.doctest('rust-bql-rs-doctests',
> _bql_rs,
> - protocol: 'rust',
> dependencies: bql_rs,
> suite: ['doc', 'rust'])
> diff --git a/rust/common/meson.build b/rust/common/meson.build
> index 7fcfa87d362..89dc11b594c 100644
> --- a/rust/common/meson.build
> +++ b/rust/common/meson.build
> @@ -34,6 +34,5 @@ rust.test('rust-common-tests', _common_rs,
> # in a separate suite that is run by the "build" CI jobs rather than "check".
> rust.doctest('rust-common-doctests',
> _common_rs,
> - protocol: 'rust',
> dependencies: common_rs,
> suite: ['doc', 'rust'])
> diff --git a/rust/migration/meson.build b/rust/migration/meson.build
> index 26e4c98bcf7..3843b364c69 100644
> --- a/rust/migration/meson.build
> +++ b/rust/migration/meson.build
> @@ -49,6 +49,5 @@ migration_rs = declare_dependency(link_with: [_migration_rs],
> # in a separate suite that is run by the "build" CI jobs rather than "check".
> rust.doctest('rust-migration-rs-doctests',
> _migration_rs,
> - protocol: 'rust',
> dependencies: migration_rs,
> suite: ['doc', 'rust'])
> diff --git a/rust/qom/meson.build b/rust/qom/meson.build
> index 3b60d2be0bd..d7622a9e0b1 100644
> --- a/rust/qom/meson.build
> +++ b/rust/qom/meson.build
> @@ -38,6 +38,5 @@ qom_rs = declare_dependency(link_with: [_qom_rs], dependencies: [qemu_macros, qo
> # in a separate suite that is run by the "build" CI jobs rather than "check".
> rust.doctest('rust-qom-rs-doctests',
> _qom_rs,
> - protocol: 'rust',
> dependencies: qom_rs,
> suite: ['doc', 'rust'])
> diff --git a/rust/util/meson.build b/rust/util/meson.build
> index ba6213bf3b8..eb101495870 100644
> --- a/rust/util/meson.build
> +++ b/rust/util/meson.build
> @@ -60,7 +60,6 @@ rust.test('rust-util-tests', _util_rs,
> # in a separate suite that is run by the "build" CI jobs rather than "check".
> rust.doctest('rust-util-rs-doctests',
> _util_rs,
> - protocol: 'rust',
> dependencies: util_rs,
> suite: ['doc', 'rust']
> )
> --
> 2.51.0
>
>
next prev parent reply other threads:[~2025-09-19 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 10:16 [PATCH] rust: build: remove "protocol: rust: from doctests Paolo Bonzini
2025-09-19 10:40 ` Manos Pitsidianakis [this message]
2025-09-23 14:42 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAjaMXbk-sr4MAejAb8vkz_Yd1u+=k3cfnCWzeOvdWigHPiu0A@mail.gmail.com' \
--to=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).