Re: [PATCH v2 10/14] rust/vmstate: Support vmstate_validate

[Paolo Bonzini <pbonzini@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Il mar 18 mar 2025, 13:03 Zhao Liu <zhao1.liu@intel.com> ha scritto:

> >  /// This macro can be used (by just passing it a type) to forward the
> `VMState`
> > @@ -572,9 +548,9 @@ const fn phantom__<T>(_: &T) ->
> ::core::marker::PhantomData<T> {
> >                  }
> >                  Some(test_cb_builder__::<$struct_name,
> _>(phantom__(&$test_fn)))
> >              },
>
> I want to keep the comment here as C version did, because there's an array
> flag
>

Ok, let's add it. No need to send v3 since it's just a single patch and
with no changes further down.

Paolo

// Though VMS_ARRAY is set, the num is 0: no data, only run test_fn callback
>
> > +            flags: VMStateFlags(VMStateFlags::VMS_MUST_EXIST.0 |
> VMStateFlags::VMS_ARRAY.0),
> >              ..$crate::zeroable::Zeroable::ZERO
> >          }
> > -        .with_validate_flag()
> >      };
> >  }
> >
> > Otherwise the series looks great, thanks!
>
> Let me refresh the v3. :-)
>
> Thanks,
> Zhao
>
>

[-- Attachment #2: Type: text/html, Size: 1822 bytes --]