From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-rust@nongnu.org,
Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Subject: Re: [PATCH 3/7] rust: migration: extract vmstate_fields_ref
Date: Thu, 25 Sep 2025 11:24:09 +0200 [thread overview]
Message-ID: <CABgObfYHfdjcitwEOiFf3c24B7T3-PgZhQMQut3UNRQ4hj1eZA@mail.gmail.com> (raw)
In-Reply-To: <aNQN7Nt7jKiA/rn1@intel.com>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Wed, Sep 24, 2025, 17:06 Zhao Liu <zhao1.liu@intel.com> wrote:
> > Considerring the idea about returing &'static [VMStateField], I think at
> > least we could return `_FIELDS.as_ptr()` directly from vmstate_fields!,
> ^^^^^^^^^^^^^^^^
> Sorry for copy error :(, s/_FIELDS.as_ptr()/_FIELDS/
>
> > and convert &'static [VMStateField] to *const [VMStateField] in
> > fields(), just like subsections() did.
>
Yes, that's a good idea. Though subsections() can also be cleaned up a lot
to avoid the wrapper. I will include everything in the next version.
Paolo
>
[-- Attachment #2: Type: text/html, Size: 1262 bytes --]
next prev parent reply other threads:[~2025-09-25 9:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 14:29 [RFC PATCH 0/7] rust: migration: add high-level migration wrappers Paolo Bonzini
2025-09-20 14:29 ` [PATCH 1/7] rust: bql: add BqlRefCell::get_mut() Paolo Bonzini
2025-09-23 15:12 ` Zhao Liu
2025-09-24 12:14 ` Paolo Bonzini
2025-09-20 14:29 ` [PATCH 2/7] rust: move VMState from bql to migration Paolo Bonzini
2025-09-23 14:46 ` Zhao Liu
2025-09-20 14:29 ` [PATCH 3/7] rust: migration: extract vmstate_fields_ref Paolo Bonzini
2025-09-24 15:21 ` Zhao Liu
2025-09-24 15:27 ` Zhao Liu
2025-09-25 9:24 ` Paolo Bonzini [this message]
2025-09-20 14:29 ` [PATCH 4/7] rust: migration: add high-level migration wrappers Paolo Bonzini
2025-09-25 9:05 ` Zhao Liu
2025-09-25 9:26 ` Paolo Bonzini
2025-09-20 14:29 ` [PATCH 5/7] rust: qemu-macros: add ToMigrationState derive macro Paolo Bonzini
2025-09-25 12:35 ` Zhao Liu
2025-09-25 16:56 ` Paolo Bonzini
2025-09-20 14:29 ` [PATCH 6/7] rust: migration: implement ToMigrationState for Timer Paolo Bonzini
2025-09-29 16:12 ` Zhao Liu
2025-09-29 16:11 ` Paolo Bonzini
2025-09-20 14:29 ` [PATCH 7/7] rust: migration: implement ToMigrationState as part of impl_vmstate_bitsized Paolo Bonzini
2025-09-30 6:53 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABgObfYHfdjcitwEOiFf3c24B7T3-PgZhQMQut3UNRQ4hj1eZA@mail.gmail.com \
--to=pbonzini@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).