From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tgjDv-0004ku-4Y for mharc-qemu-rust@gnu.org; Sat, 08 Feb 2025 06:42:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgjDo-0004jO-D4 for qemu-rust@nongnu.org; Sat, 08 Feb 2025 06:42:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgjDm-00009c-Js for qemu-rust@nongnu.org; Sat, 08 Feb 2025 06:42:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739014921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=maZD1J7qe8nz1qcfpE3E3EO+M+U+/67hJTDDAF24NTA=; b=aSb/M2yzbWCPZ79DfDWEs/2+WIaFfaaXk2T8/cDClSrPY8hYZQf+IVfKbcwPn1HZ7tNkP7 evXzZY491M67QYmUEiCPcKPxVfybTubkjkpXpVDP355IMLrw4DtTeSxhWiQlbKsv/HmX3L QWdmESdKpUyJB/gfX+8Ti0K7au/KaG8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-QUf9eL6cMmaI0mzezJBsNA-1; Sat, 08 Feb 2025 06:41:58 -0500 X-MC-Unique: QUf9eL6cMmaI0mzezJBsNA-1 X-Mimecast-MFC-AGG-ID: QUf9eL6cMmaI0mzezJBsNA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-438da39bb69so22380605e9.0 for ; Sat, 08 Feb 2025 03:41:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739014917; x=1739619717; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=maZD1J7qe8nz1qcfpE3E3EO+M+U+/67hJTDDAF24NTA=; b=QeIGDAWFoASe4b3k6JejW3pNuEHSxCJ7h89vLPA6FXPttn4/YnjArRjUqmzufGGZ1+ przqy/ZZbl1vFPrEXZT6Lk+khKxgGxpVnykKInW/X65arsnLM0Fc8i0vjH2O3tyYccg5 jMV05ymAiCaw69+CDWXmLXLN9DOW/1+DM35241svRn4VCPBMxOAv84MnGWE1UkEuxZki Ed2Wkaqjeq+2z411nJgybS2E4xFACRH9bm5v+gX25kdxIAEBq0HmnLY0iQSagt5iw6Us 8seMnoJT0UJ/WbYuKxCZANohB45BVAGUwVqMlcnUvf4o01dNtXSpjAuTyktbI3waZQF2 40Lg== X-Forwarded-Encrypted: i=1; AJvYcCXFbTI54wMweg+S+CsvwsXAsvJJ16Y651QBt2FSgdgo0VfrhNl9KS/y3XU01iJweEffPcJMv/4mVdE=@nongnu.org X-Gm-Message-State: AOJu0YyDQrLNSM1hE1nXVmQdX0AfrFy4QLQA91g9T+T4iOiEckvFJQCZ 0YR0cjWRDGpcWVmTmxFnAXKiBALlYok3xHv5XbWCZmTm4s0MN14MO8x8HMEBGUs5DiHV9oij0r6 3C7gbQt3/QJ2suqFUPtkXHZzf96spQKnh1i3ciq0/0gmw9ha3UlQGyzz6UDpjOk5r7Mb84miJOf qywwBOEh9QfkQdDdmNBneSroh38Q== X-Gm-Gg: ASbGncuLNdaqdse5tkYf+4nAPveZm5MYmSy9rFr9/u945FnqgoxwrEwO4vLrKYEWaAH jkXAltyITEnSVbz4TVpTzpugRuBB1u/XVc54qD9aVzG86PnaMEnOkkXE9X6Ng X-Received: by 2002:a05:600c:5114:b0:434:ff25:199f with SMTP id 5b1f17b1804b1-439249bd37amr44187135e9.26.1739014916897; Sat, 08 Feb 2025 03:41:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/z/wQmFR+hBCckctW3ra7mTId9fgNj32ARS6AWKCjEgQDugBDwEd+r2+y7LLUJhjfIW8F1mqlySodlfE9knc= X-Received: by 2002:a05:600c:5114:b0:434:ff25:199f with SMTP id 5b1f17b1804b1-439249bd37amr44187015e9.26.1739014916511; Sat, 08 Feb 2025 03:41:56 -0800 (PST) MIME-Version: 1.0 References: <20250125125137.1223277-1-zhao1.liu@intel.com> <20250125125137.1223277-10-zhao1.liu@intel.com> <750f06f3-6326-473f-9d08-ad6bb1f2a54a@redhat.com> In-Reply-To: From: Paolo Bonzini Date: Sat, 8 Feb 2025 12:41:46 +0100 X-Gm-Features: AWEUYZnqdVIEI_vtj_tEa75yeqkNsx3cSDBhwhqh5nevaZZ40emRmJxKla14knc Message-ID: Subject: Re: [PATCH 09/10] rust/timer/hpet: add qom and qdev APIs support To: Zhao Liu Cc: Manos Pitsidianakis , Junjie Mao , =?UTF-8?B?QWxleCBCZW5uw6ll?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Richard Henderson , Peter Maydell , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-devel , qemu-rust@nongnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZeP-ryfPckC6bMY8Ek47Oq3yV3o7Lh5tL6V_gupCTwo_1739014917 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000005bbf20062d9ff6ca" Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Feb 2025 11:42:09 -0000 --0000000000005bbf20062d9ff6ca Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Il sab 8 feb 2025, 11:36 Zhao Liu ha scritto: > On Wed, Jan 29, 2025 at 11:58:14AM +0100, Paolo Bonzini wrote: > > Date: Wed, 29 Jan 2025 11:58:14 +0100 > > From: Paolo Bonzini > > Subject: Re: [PATCH 09/10] rust/timer/hpet: add qom and qdev APIs suppo= rt > > > > > > > > On Sat, Jan 25, 2025 at 1:32=E2=80=AFPM Zhao Liu = wrote: > > > fn read(&mut self, addr: hwaddr, _size: u32) -> u64 { > > > > This can be &self. > > Done. > > > > let shift: u64 =3D (addr & 4) * 8; > > > > > > + match addr { > > > + HPET_TN_CFG_REG =3D> self.config >> shift, // including > interrupt capabilities > > > > This needs to be "match addr & !4". > > I understand it's not necessary: > > In timer_and_addr(), I've masked the address with 0x18. > > fn timer_and_addr(&self, addr: hwaddr) -> > Option<(&BqlRefCell, hwaddr)> { > let timer_id: usize =3D ((addr - 0x100) / 0x20) as usize; > > if timer_id > self.num_timers.get() { > None > } else { > Some((&self.timers[timer_id], addr & 0x18)) > Ah, this should be 0x1C (or perhaps 0x1F). Otherwise there is a bug in accessing the high 32 bits of a 64-bit register; shift will always be 0 in HPETTimer::read and write. // No need for HPETClass. Just like OBJECT_DECLARE_SIMPLE_TYPE in C. > > Then this can be "grep", as a reference. > Sure. Thanks, Paolo > > type Class =3D ::Class; > > const TYPE_NAME: &'static CStr =3D crate::TYPE_HPET; > > } > > > > which is indeed more similar to OBJECT_DECLARE_SIMPLE_TYPE(). > > Awesome! Thanks. > > Regards, > Zhao > > --0000000000005bbf20062d9ff6ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Il sab 8 feb 2025, 11:36 Zhao Li= u <zhao1.liu@intel.com> ha= scritto:
On Wed= , Jan 29, 2025 at 11:58:14AM +0100, Paolo Bonzini wrote:
> Date: Wed, 29 Jan 2025 11:58:14 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH 09/10] rust/timer/hpet: add qom and qdev APIs supp= ort
>
>
>
> On Sat, Jan 25, 2025 at 1:32=E2=80=AFPM Zhao Liu <zhao1.liu@intel.= com> wrote:
> >=C2=A0 =C2=A0 =C2=A0 fn read(&mut self, addr: hwaddr, _size: u= 32) -> u64 {
>
> This can be &self.

Done.

> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 let shift: u64 =3D (addr & = 4) * 8;
> >
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 match addr {
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 HPET_TN_CFG_REG =3D>= ; self.config >> shift, // including interrupt capabilities
>
> This needs to be "match addr & !4".

I understand it's not necessary:

In timer_and_addr(), I've masked the address with 0x18.

=C2=A0 =C2=A0 fn timer_and_addr(&self, addr: hwaddr) -> Option<(&= amp;BqlRefCell<HPETTimer>, hwaddr)> {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 let timer_id: usize =3D ((addr - 0x100) / 0x20)= as usize;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if timer_id > self.num_timers.get() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 None
=C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Some((&self.timers[timer_id],= addr & 0x18))

=
Ah, this should be 0x1C (or perhaps 0x1F). Otherwise ther= e is a bug in accessing the high 32 bits of a 64-bit register; shift will a= lways be 0 in HPETTimer::read and write.

<= div dir=3D"auto">
// No need for HPETClass. Just lik= e OBJECT_DECLARE_SIMPLE_TYPE in C.

Then this can be "grep", as a reference.

Sure.

Thanks,

Paolo


>=C2=A0 =C2=A0 =C2=A0type Class =3D <SysBusDevice as ObjectType>::= Class;
>=C2=A0 =C2=A0 =C2=A0 const TYPE_NAME: &'static CStr =3D crate::= TYPE_HPET;
> }
>
> which is indeed more similar to OBJECT_DECLARE_SIMPLE_TYPE().

Awesome! Thanks.

Regards,
Zhao

--0000000000005bbf20062d9ff6ca--