From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tiXMH-0007Fp-DP for mharc-qemu-rust@gnu.org; Thu, 13 Feb 2025 06:26:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiXMF-0007FL-Cq for qemu-rust@nongnu.org; Thu, 13 Feb 2025 06:26:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiXMB-0001zS-Oe for qemu-rust@nongnu.org; Thu, 13 Feb 2025 06:26:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739445969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhy8q4kc/c0WUONMdwjUk0ZpxTbe02QgZdW7hW6aAmw=; b=YAcHOgyaUwmJRTRNt37GkMYGG5+YRMp7xOghk9wR4aYOqhvVYBQueFfqXxgb0H3aYTn2Xw CY99OgoXMJDkWNNUJrfEcFOikd2fEO8/l74nCdxxuMmOO7Z7VUnaVXs+a4bE9dGv3DTQtU I93zzbjwh88kNppyADtpKFvbk+VJL3I= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-eIbET_XpN42zvSFb2C0c5w-1; Thu, 13 Feb 2025 06:26:07 -0500 X-MC-Unique: eIbET_XpN42zvSFb2C0c5w-1 X-Mimecast-MFC-AGG-ID: eIbET_XpN42zvSFb2C0c5w Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38dd533dad0so547884f8f.0 for ; Thu, 13 Feb 2025 03:26:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739445966; x=1740050766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhy8q4kc/c0WUONMdwjUk0ZpxTbe02QgZdW7hW6aAmw=; b=r4AF5pnr8o0hE9M2d5XQ17DoOFRF2gnOVgjLAm/GUy9CYfGQAWe9GwcfhUy7+EvwWv 4Jj5kznQyyDlB5r/pkMiKt4dwLWqMiIwnWHl6j+aXdHfrhtO6GND7chIH4AFvFTnwPZE j24gHKYtQwrIUdZ1gy0/VABoKw4imLyZzn9chtoAwkRNz9etbBg7Odn041Sa2Bp7/sLK vrYozyzXWfNtzv1cxqAIjwHRMkF+UaHFxwJR0QeFVDMYQ6wPDQkZyrVYC3ECsvnFS2TM S4whh5CGH6SsoaU8c+V8huY1VH4uhqoHt1ONZuntZKUUORoakb6FCrS2n6e65tevy/aj DEeA== X-Forwarded-Encrypted: i=1; AJvYcCVRJlAj18OlBk+fYwwIqHnzzfaFz9sYvstfolct+zeY5A8+St8Krt4c7R/F/RqGiCA2ByBAcjZucF0=@nongnu.org X-Gm-Message-State: AOJu0Yy58hy2cfjvDDr/H5tBrMV9/SsD1H370JYR7X0bOeT+X16VZJrA dvbhL6PD+eCarpEjIv4cM5sp7caKzLy7tUIJD2vjeVhh7IXGa4SCfKQneKm5vwf5mGdtWaNzemY O4txt6SGiCcOorVm3PzizjT3IM2+MJAOn9RC8haqv8T0Pudh8pcLwiB264hqR/IQv4S5CBnihVO vc9FWR9jaJLMj67NmF3cZtaiRv1g== X-Gm-Gg: ASbGncswM1FTvD4JTuDpGemRDujinEWj1DkLVWN3lUMcPYAnChZbqMQHTx8NlUZ3Bxb hGKeTetox/tITlQH811xgSrl3ePGokDYy6Ke5uvGL4PqYesc0cqspZ9TfA0EQp78= X-Received: by 2002:a05:6000:2ab:b0:38d:d39a:d13c with SMTP id ffacd0b85a97d-38dea256ee7mr6600885f8f.2.1739445966704; Thu, 13 Feb 2025 03:26:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjOABVMMJQBbuPDEbTE1atpPLosKxPvaHqvJvlxSdC9zQrx8z37JNI8nwRW/TaUP+YSz4ZRgL1aJAk6yhZdl8= X-Received: by 2002:a05:6000:2ab:b0:38d:d39a:d13c with SMTP id ffacd0b85a97d-38dea256ee7mr6600850f8f.2.1739445966313; Thu, 13 Feb 2025 03:26:06 -0800 (PST) MIME-Version: 1.0 References: <20250210030051.2562726-1-zhao1.liu@intel.com> <20250210030051.2562726-2-zhao1.liu@intel.com> In-Reply-To: <20250210030051.2562726-2-zhao1.liu@intel.com> From: Paolo Bonzini Date: Thu, 13 Feb 2025 12:25:55 +0100 X-Gm-Features: AWEUYZnbblVJEqx9xEzitGZ2-FQk6-BUDOz6tMzGvwZI1lgi26sUhJORBpm5muU Message-ID: Subject: Re: [PATCH v2 01/10] i386/fw_cfg: move hpet_cfg definition to hpet.c To: Zhao Liu Cc: Manos Pitsidianakis , Junjie Mao , =?UTF-8?B?QWxleCBCZW5uw6ll?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Richard Henderson , Peter Maydell , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org, qemu-rust@nongnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NmNuFIeDjRg3gffBGbRr04vXjAtt4qrdFKPqUwZgkac_1739445967 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Feb 2025 11:26:15 -0000 On Mon, Feb 10, 2025 at 3:41=E2=80=AFAM Zhao Liu wrot= e: > diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c > index d2cb08715a21..546de63123e6 100644 > --- a/hw/i386/fw_cfg.c > +++ b/hw/i386/fw_cfg.c > @@ -26,8 +26,6 @@ > #include CONFIG_DEVICES > #include "target/i386/cpu.h" > > -struct hpet_fw_config hpet_cfg =3D {.count =3D UINT8_MAX}; This must be kept for the case where HPET is not enabled at all in the build; removing the FW_CFG_HPET file changes the guest API and I'd prefer to merge the Rust HPET implementation without having to figure out the safety of that change. No need to do anything, I'll just make it #if !defined(CONFIG_HPET) && !defined(CONFIG_X_HPET_RUST) const struct hpet_fw_config hpet_fw_cfg =3D {.count =3D UINT8_MAX}; #endif Paolo