qemu-rust.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] gitlab-ci: include full Rust backtraces in test runs
Date: Mon, 10 Mar 2025 10:31:51 +0000	[thread overview]
Message-ID: <CAFEAcA8bbXBYy774AMFo=yiRSN4qZnOyaC+sOV0zP11d49mUvg@mail.gmail.com> (raw)
In-Reply-To: <CABgObfbuj3SbqpDkUnKux1EWCudiksQxbWr_4Sck5tTLr5QqeA@mail.gmail.com>

On Mon, 10 Mar 2025 at 09:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On Mon, Mar 10, 2025 at 10:25 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > This will only add the rust backtraces when the tests
> > > are run from the CI logs, not when you locally run
> > > "make check" or similar. There's probably a better place
> > > to put this...
> >
> > Meson's  'test()' command accepts env variables, but it'll be somewhat
> > tedious to add the same env to all case where we use test. Might want
> > to define a common 'testenv' set at the top level meson.build and then
> > reference it from every 'test()', unless meson has built-in support
> > for globally applied env vars that I'm missing.
>
> It can be added to add_test_setup().

Thanks -- I just sent a patch to do it that way:

https://patchew.org/QEMU/20250310102950.3752908-1-peter.maydell@linaro.org/

-- PMM


      reply	other threads:[~2025-03-10 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29  8:20 [PATCH] gitlab-ci: include full Rust backtraces in test runs Paolo Bonzini
2025-01-29  8:26 ` Philippe Mathieu-Daudé
2025-01-29  8:26 ` Thomas Huth
2025-03-10  9:21 ` Peter Maydell
2025-03-10  9:25   ` Daniel P. Berrangé
2025-03-10  9:35     ` Peter Maydell
2025-03-10  9:40     ` Paolo Bonzini
2025-03-10 10:31       ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA8bbXBYy774AMFo=yiRSN4qZnOyaC+sOV0zP11d49mUvg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).