From: Junjie Mao <junjie.mao@hotmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, manos.pitsidianakis@linaro.org,
kwolf@redhat.com, zhao1.liu@intel.com, qemu-rust@nongnu.org
Subject: Re: [RFC PATCH 02/11] rust: build: move rustc_args.py invocation to individual crates
Date: Tue, 12 Nov 2024 11:02:22 +0800 [thread overview]
Message-ID: <SY0P300MB102652560AD744516054AE1495592@SY0P300MB1026.AUSP300.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20241108180139.117112-3-pbonzini@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> Only qemu-api needs access to the symbols in config-host.h.
This may no longer be the case when more complex, build-time
configurable devices are added in the future.
Moving rustc_args.py calls to each crate is still helpful because of the
changes in patches 3-6 in this series. So I think every crate under
rust/ needs a run_command(rustc_args, ...) for crate-specific arguments.
--
Best Regards
Junjie Mao
> Remove
> the temptation to use them by limiting the --cfg arguments to the
> qemu-api crate.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> meson.build | 54 +++++++++++++++++----------------------
> rust/qemu-api/meson.build | 4 +++
> 2 files changed, 28 insertions(+), 30 deletions(-)
next prev parent reply other threads:[~2024-11-12 3:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241108180139.117112-1-pbonzini@redhat.com>
[not found] ` <20241108180139.117112-12-pbonzini@redhat.com>
2024-11-08 18:12 ` [RFC PATCH 11/11] rust: ci: add job that runs Rust tools Daniel P. Berrangé
[not found] ` <20241108180139.117112-3-pbonzini@redhat.com>
2024-11-12 3:02 ` Junjie Mao [this message]
[not found] ` <20241108180139.117112-6-pbonzini@redhat.com>
[not found] ` <SY0P300MB1026324D1571BBD2E001536695592@SY0P300MB1026.AUSP300.PROD.OUTLOOK.COM>
[not found] ` <CABgObfZUURf_QpdtqzmGF567Uk8obxdQ1P_WeVN1Ag=uG+J46A@mail.gmail.com>
2024-11-12 5:40 ` [RFC PATCH 05/11] rust: cargo: store desired warning levels in workspace Cargo.toml Junjie Mao
[not found] ` <20241108180139.117112-2-pbonzini@redhat.com>
[not found] ` <SY0P300MB102699E99096F482F06296EF95592@SY0P300MB1026.AUSP300.PROD.OUTLOOK.COM>
[not found] ` <CABgObfb9ujpoRrNUUqyiAefSfTOWSV-SGmo2YrSoMdfxBeAD9A@mail.gmail.com>
2024-11-12 10:10 ` [RFC PATCH 01/11] rust: qemu_api: do not disable lints outside bindgen-generated code Junjie Mao
2024-11-12 18:47 ` Paolo Bonzini
2024-11-13 6:46 ` Junjie Mao
2024-11-13 10:41 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SY0P300MB102652560AD744516054AE1495592@SY0P300MB1026.AUSP300.PROD.OUTLOOK.COM \
--to=junjie.mao@hotmail.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).