From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tuVXc-00056m-3z for mharc-qemu-rust@gnu.org; Tue, 18 Mar 2025 07:55:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuVXW-000565-75 for qemu-rust@nongnu.org; Tue, 18 Mar 2025 07:55:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuVXU-0003tw-Ib for qemu-rust@nongnu.org; Tue, 18 Mar 2025 07:55:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742298918; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x1yqtzfKxG2zu6m5LfqDvloNdABDX3NgDNb0KbZo22A=; b=Nd7PjEo/BxpMgqOJY708MOOtPmufiGCXqi37/yLl3XodalOcvoqoa0pyoL0gmzRMjyy1Ir fJbLWxHGyetB+dj/mCXJ+I+jhpCC/9fdG8YqUhEJSxhGLPnxuhqL1666FmGDZMgdH3nuGg jnz54ryTvEkKXxHgRMLsM2SIrOpjEFo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-t19GnOxdOD6ONvH022ngsA-1; Tue, 18 Mar 2025 07:55:14 -0400 X-MC-Unique: t19GnOxdOD6ONvH022ngsA-1 X-Mimecast-MFC-AGG-ID: t19GnOxdOD6ONvH022ngsA_1742298913 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 094DD180025C; Tue, 18 Mar 2025 11:55:12 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.167]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41CD63001D0E; Tue, 18 Mar 2025 11:55:09 +0000 (UTC) Date: Tue, 18 Mar 2025 11:55:05 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-rust@nongnu.org Subject: Re: [PATCH] rust: pl011: Cut down amount of text quoted from PL011 TRM Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20250317173239.941034-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250317173239.941034-1-peter.maydell@linaro.org> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.332, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Mar 2025 11:55:25 -0000 On Mon, Mar 17, 2025 at 05:32:39PM +0000, Peter Maydell wrote: > Currently the comments in the Rust pl011 register.rs file include > large amounts of text from the PL011 TRM. This is much more > commentary than we typically quote from a device reference manual, > and much of it is not relevant to QEMU. Compress and rephrase the > comments so that we are not quoting such a large volume of TRM text. > > We add a URL for the TRM; readers who need more detail on the > function of the register bits can find it there, presented in > context with the overall description of the hardware. > > Signed-off-by: Peter Maydell > --- > rust/hw/char/pl011/src/registers.rs | 261 ++++++---------------------- > 1 file changed, 51 insertions(+), 210 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|