From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tEEIf-0006ZP-0z for mharc-qemu-rust@gnu.org; Thu, 21 Nov 2024 16:01:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tECSb-0005cn-4e for qemu-rust@nongnu.org; Thu, 21 Nov 2024 14:03:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tECSY-00074k-Vr for qemu-rust@nongnu.org; Thu, 21 Nov 2024 14:03:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732215802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aP1v1hQXZ39XefNc3OtxF2PCA/2zFy7aoMy3EmvieKk=; b=XmSubXmedSQ2imBmosJSFSbJi94dzji5TVMGS0zT9gK0N6OHKjY2H8achP27ks9p8B1iau B2sTeMSeNWRttITiinRlNyb3D28dWSDdlv+Uahqxn2yR4ElFrl6Jne/QEKHkisUN6KjVJA boLXV1EmWem/JbFe7ZOxt0mBlzpjp/g= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-xmSc73AmNqy_fy9W7cz9PA-1; Thu, 21 Nov 2024 14:03:20 -0500 X-MC-Unique: xmSc73AmNqy_fy9W7cz9PA-1 X-Mimecast-MFC-AGG-ID: xmSc73AmNqy_fy9W7cz9PA Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5cf735604aeso1211905a12.0 for ; Thu, 21 Nov 2024 11:03:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732215798; x=1732820598; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aP1v1hQXZ39XefNc3OtxF2PCA/2zFy7aoMy3EmvieKk=; b=e+vxNvCwnJ9ha6qSEUcpijZLu0GRK8sBdvHEfK4oJYmYp8YuhNyYBQDMn8wqa4zDgt LxeKmtGRcANXXfRAHVR9Kg3Xm8KV8THp6JowlyNscjI/8pAawE/kZT8nBmKcvdnfrUHd IGRTs5LOwjEEclyeRqsrGOTVuzM6/VxxoKij/S0UKyjJmxNkLVpJJcYS38uwW9VUPHPC OT6zGwFmWCmJz0m9R7zeK715LRNOWD3P4OcoT2Yjjs+IjP7y+bqFeHaRHeREcJ7g5kBn 4xTL4YaT3WClLGdDRtQYozCUhjsbl8VWxc6MYuskDaEKJhk7LaQuz9ThgHFoL3epguzk LIQQ== X-Forwarded-Encrypted: i=1; AJvYcCXWjgOijeIbAlOr78L7qWRIxw1TKU33bOeJLKuFiVNOoW78Ue4XFndOW0HTgkPwnAoJxPXOl3l23ts=@nongnu.org X-Gm-Message-State: AOJu0YzPISLmybT6rE6Sndopnp21+aYZVWFVWqHDXX634WHK4yppnKTp 3GzJ5r/WjL0ZOjpdph6QBg+7LV1gaHjj2r2g7WO/kPsLXibe8em0/A2YB7WWFXwqZGv2GeeYXTB jLRnOeY3MC/jfd9J6W92/Q6je7wN5qGn/Zbhy17vRuAOf4VyQs1E= X-Gm-Gg: ASbGncs/g9NzgMoVBBSv/f451uSG6nS6KfxHSPIQrQVEuF6uFaegtnUkkkZMz6XSiC0 uNzcW7wUT41wJIxR4KtSlzEsXQP1D+FtYjLtz89wbBH5gNVQvXMMQR4/kYC7hdSiglC43r0t2EF U3UQbJjWj7s9YQIEnLnoDETLDzaYgkCBFs2vf5MXzWuCL3YMprHd4GR9mf2T801U8e9Mq4LP4s4 x7IObbvSrd4rGgX1cCjHJnzFBX//1Sd4XDUexI63RQV7Ezh6PWhM166ESL37xO5p9l7Yrb1xtYv 2wE= X-Received: by 2002:a17:906:18b2:b0:aa5:a22:8f5b with SMTP id a640c23a62f3a-aa50a2291camr22538666b.38.1732215798499; Thu, 21 Nov 2024 11:03:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdzCW6KHFVBFtI3X5U3LmCdF/YbaydrsFedhf9NvbbZRBubwLtI87sHuAM3SD7Oo+liFg91w== X-Received: by 2002:a17:906:18b2:b0:aa5:a22:8f5b with SMTP id a640c23a62f3a-aa50a2291camr22533966b.38.1732215798121; Thu, 21 Nov 2024 11:03:18 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-51-70.web.vodafone.de. [109.42.51.70]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa50b2f4d94sm4553066b.63.2024.11.21.11.03.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 11:03:17 -0800 (PST) Message-ID: Date: Thu, 21 Nov 2024 20:03:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/39] tests/functional: logs details of console interaction operations To: =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Daniel Henrique Barboza , Pierrick Bouvier , Harsh Prateek Bora , Marcel Apfelbaum , Jiaxun Yang , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Daniel Henrique Barboza , Alexandre Iooss , qemu-riscv@nongnu.org, Thomas Huth , Bernhard Beschow , Eric Farman , Bin Meng , qemu-s390x@nongnu.org, Niek Linnenbank , qemu-arm@nongnu.org, John Snow , Wainer dos Santos Moschetta , Cleber Rosa , qemu-rust@nongnu.org, Nicholas Piggin , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Palmer Dabbelt , Markus Armbruster , Weiwei Li , Mahmoud Mandour , Mark Cave-Ayland , Liu Zhiwei , Aurelien Jarno , Ani Sinha , Alistair Francis References: <20241121165806.476008-1-alex.bennee@linaro.org> <20241121165806.476008-13-alex.bennee@linaro.org> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20241121165806.476008-13-alex.bennee@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uStMBTN30QFMzCiGwLdYRS1-ufZCgO0Fy4dZEks6xJw_1732215798 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.14, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 21 Nov 2024 16:01:12 -0500 X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2024 19:03:25 -0000 On 21/11/2024 17.57, Alex Bennée wrote: > From: Daniel P. Berrangé > > When functional tests go wrong, it will often be related to the console > interaction wait state. By logging the messages that we're looking for, > and data we're about to be sending, it'll be easier to diagnose where > tests are getting stuck. > > Signed-off-by: Daniel P. Berrangé > Message-Id: <20241121154218.1423005-13-berrange@redhat.com> > Signed-off-by: Alex Bennée > --- > tests/functional/qemu_test/cmd.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test/cmd.py > index cbabb1ceed..98722a9cf6 100644 > --- a/tests/functional/qemu_test/cmd.py > +++ b/tests/functional/qemu_test/cmd.py > @@ -85,6 +85,9 @@ def _console_interaction(test, success_message, failure_message, > vm = test.vm > console = vm.console_file > console_logger = logging.getLogger('console') > + test.log.debug( > + f"Console interaction: success_msg='{success_message}' " + > + f"failure_msg='{failure_message}' send_string='{send_string}'") > while True: > if send_string: > vm.console_socket.sendall(send_string.encode()) Reviewed-by: Thomas Huth