qemu-rust.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Martin Kletzander <mkletzan@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-rust@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>
Subject: Re: [PATCH 2/2] tests/qemu-iotests: Indent expected error messages
Date: Mon, 4 Aug 2025 10:20:01 +0200	[thread overview]
Message-ID: <aJBtMUczl93scBnN@wheatley.k8r.cz> (raw)
In-Reply-To: <87v7n63lld.fsf@suse.de>

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On Fri, Aug 01, 2025 at 04:09:34PM -0300, Fabiano Rosas wrote:
>Daniel P. Berrangé <berrange@redhat.com> writes:
>
>> On Fri, Aug 01, 2025 at 04:59:50PM +0200, Martin Kletzander wrote:
>>> From: Martin Kletzander <mkletzan@redhat.com>
>>>
>>> When running all tests the expected "killed" messages are indented
>>> differently than the actual ones, by three more spaces.  Change it so
>>> that the messages match and tests pass.
>>
>> This would break the tests on my system and CI too.
>>
>> What distro are you seeing this on ?
>>
>> I'm guessing this is a different in either valgrind or C library ?
>>
>
>It's bash, we have an open issue about it:
>
>https://gitlab.com/qemu-project/qemu/-/issues/3050
>

Ah, good to know, thanks.  That's what I suspected, but haven't thought of
checking gitlab issues.  Sorry for the noise.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-08-04  8:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 14:59 [PATCH 0/2] Few fixes I found when building QEMU with Rust Martin Kletzander
2025-08-01 14:59 ` [PATCH 1/2] rust: Add antoher variant for impl_vmstate_struct! macro Martin Kletzander
2025-08-01 21:44   ` Paolo Bonzini
2025-08-04  8:56     ` Martin Kletzander
2025-08-04 10:08       ` Paolo Bonzini
2025-08-04 12:04         ` Martin Kletzander
2025-08-04 13:06           ` Paolo Bonzini
2025-08-01 14:59 ` [PATCH 2/2] tests/qemu-iotests: Indent expected error messages Martin Kletzander
2025-08-01 15:48   ` Daniel P. Berrangé
2025-08-01 19:09     ` Fabiano Rosas
2025-08-04  8:20       ` Martin Kletzander [this message]
2025-08-04 11:33       ` Kevin Wolf
2025-08-06  6:54         ` Dr. Werner Fink
2025-08-11  9:05           ` Martin Kletzander
2025-08-12 15:35             ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJBtMUczl93scBnN@wheatley.k8r.cz \
    --to=mkletzan@redhat.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).