From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] subprojects: Update .gitignore for syn
Date: Tue, 30 Sep 2025 09:08:23 +0100 [thread overview]
Message-ID: <aNuP98uhOzOd5glp@redhat.com> (raw)
In-Reply-To: <20250930075351.1853721-1-zhao1.liu@intel.com>
On Tue, Sep 30, 2025 at 03:53:51PM +0800, Zhao Liu wrote:
> The commit a530a8d4ac39 missed to update syn version, this is because
> the code base of its v2 patch has fixed syn version, so that the fix for
> syn were lost during the rebase from v1 to v2.
>
> To rectify this mistake, update the syn version.
>
> Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> subprojects/.gitignore | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/subprojects/.gitignore b/subprojects/.gitignore
> index 58a29f012044..136e30cd99ad 100644
> --- a/subprojects/.gitignore
> +++ b/subprojects/.gitignore
> @@ -19,7 +19,7 @@
> /proc-macro-error-attr-1.0.4
> /proc-macro2-1.0.95
> /quote-1.0.36
> -/syn-2.0.66
> +/syn-2.0.104
> /unicode-ident-1.0.12
IMHO we should get rid of all the version numbers, and use wildcard
matches instead, to eliminate the bug scenario entirely, as people
will repeatedly forgot to change these versions.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-09-30 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 7:53 [PATCH] subprojects: Update .gitignore for syn Zhao Liu
2025-09-30 7:50 ` Philippe Mathieu-Daudé
2025-09-30 8:18 ` Zhao Liu
2025-09-30 8:00 ` Philippe Mathieu-Daudé
2025-09-30 8:08 ` Daniel P. Berrangé [this message]
2025-09-30 8:56 ` Zhao Liu
2025-09-30 9:22 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNuP98uhOzOd5glp@redhat.com \
--to=berrange@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).