From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A31AACAC5B9 for ; Tue, 30 Sep 2025 08:08:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VPi-0002u1-33; Tue, 30 Sep 2025 04:08:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VPh-0002th-4T for qemu-rust@nongnu.org; Tue, 30 Sep 2025 04:08:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VPZ-0004KH-I6 for qemu-rust@nongnu.org; Tue, 30 Sep 2025 04:08:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759219714; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8qSx7+ZzzZP8fWOz/hxAVCcPbe1k8lKlExsvrZBqM1I=; b=e0Pb6FJWx3kPYxsNKrhQ6O8zYotd3E6fpRJ8rUgJOZPHOU6BxCcHPSV5HBMjxAD8nsyyTj TW402YAD/T7Dq+YpsU25qkQSVTh/p0EupvtjuqRcgqRTLkSwjA4LfB35+iTYPLjbRi1Dmn eYbQRUUTWtQaKbq4h6F3QFWJhkcdRO4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-mcYFq2I0P6Wsgj9WUFi69A-1; Tue, 30 Sep 2025 04:08:29 -0400 X-MC-Unique: mcYFq2I0P6Wsgj9WUFi69A-1 X-Mimecast-MFC-AGG-ID: mcYFq2I0P6Wsgj9WUFi69A_1759219708 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8FBBE1800372; Tue, 30 Sep 2025 08:08:28 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.102]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9877230003BA; Tue, 30 Sep 2025 08:08:26 +0000 (UTC) Date: Tue, 30 Sep 2025 09:08:23 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Zhao Liu Cc: Paolo Bonzini , Manos Pitsidianakis , qemu-devel@nongnu.org, qemu-rust@nongnu.org Subject: Re: [PATCH] subprojects: Update .gitignore for syn Message-ID: References: <20250930075351.1853721-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250930075351.1853721-1-zhao1.liu@intel.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On Tue, Sep 30, 2025 at 03:53:51PM +0800, Zhao Liu wrote: > The commit a530a8d4ac39 missed to update syn version, this is because > the code base of its v2 patch has fixed syn version, so that the fix for > syn were lost during the rebase from v1 to v2. > > To rectify this mistake, update the syn version. > > Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn") > Signed-off-by: Zhao Liu > --- > subprojects/.gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore > index 58a29f012044..136e30cd99ad 100644 > --- a/subprojects/.gitignore > +++ b/subprojects/.gitignore > @@ -19,7 +19,7 @@ > /proc-macro-error-attr-1.0.4 > /proc-macro2-1.0.95 > /quote-1.0.36 > -/syn-2.0.66 > +/syn-2.0.104 > /unicode-ident-1.0.12 IMHO we should get rid of all the version numbers, and use wildcard matches instead, to eliminate the bug scenario entirely, as people will repeatedly forgot to change these versions. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|