Re: [PATCH] subprojects: Update .gitignore for syn

Re: [PATCH] subprojects: Update .gitignore for syn

[Philippe Mathieu-Daudé]

On 30/9/25 09:53, Zhao Liu wrote:
> The commit a530a8d4ac39 missed to update syn version, this is because
> the code base of its v2 patch has fixed syn version, so that the fix for
> syn were lost during the rebase from v1 to v2.
> 
> To rectify this mistake, update the syn version.
> 
> Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")

IIUC the subprojects is in commit 9a6d6ae8afb, so:

Fixes: 9a6d6ae8afb ("subprojects: update proc-macro2 and syn")

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   subprojects/.gitignore | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/subprojects/.gitignore b/subprojects/.gitignore
> index 58a29f012044..136e30cd99ad 100644
> --- a/subprojects/.gitignore
> +++ b/subprojects/.gitignore
> @@ -19,7 +19,7 @@
>   /proc-macro-error-attr-1.0.4
>   /proc-macro2-1.0.95
>   /quote-1.0.36
> -/syn-2.0.66
> +/syn-2.0.104
>   /unicode-ident-1.0.12
>   
>   # Workaround for Meson v1.9.0 https://github.com/mesonbuild/meson/issues/14948

[PATCH] subprojects: Update .gitignore for syn

[Zhao Liu]

The commit a530a8d4ac39 missed to update syn version, this is because
the code base of its v2 patch has fixed syn version, so that the fix for
syn were lost during the rebase from v1 to v2.

To rectify this mistake, update the syn version.

Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 subprojects/.gitignore | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/subprojects/.gitignore b/subprojects/.gitignore
index 58a29f012044..136e30cd99ad 100644
--- a/subprojects/.gitignore
+++ b/subprojects/.gitignore
@@ -19,7 +19,7 @@
 /proc-macro-error-attr-1.0.4
 /proc-macro2-1.0.95
 /quote-1.0.36
-/syn-2.0.66
+/syn-2.0.104
 /unicode-ident-1.0.12
 
 # Workaround for Meson v1.9.0 https://github.com/mesonbuild/meson/issues/14948
-- 
2.34.1

Re: [PATCH] subprojects: Update .gitignore for syn

[Philippe Mathieu-Daudé]

On 30/9/25 10:18, Zhao Liu wrote:
> On Tue, Sep 30, 2025 at 09:50:24AM +0200, Philippe Mathieu-Daudé wrote:
>> Date: Tue, 30 Sep 2025 09:50:24 +0200
>> From: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Subject: Re: [PATCH] subprojects: Update .gitignore for syn
>>
>> On 30/9/25 09:53, Zhao Liu wrote:
>>> The commit a530a8d4ac39 missed to update syn version, this is because
>>> the code base of its v2 patch has fixed syn version, so that the fix for
>>> syn were lost during the rebase from v1 to v2.
>>>
>>> To rectify this mistake, update the syn version.
>>>
>>> Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
>>
>> IIUC the subprojects is in commit 9a6d6ae8afb, so:
>>
>> Fixes: 9a6d6ae8afb ("subprojects: update proc-macro2 and syn")
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> It's because the subject of a530a8d4ac39 mentioned to fix syn but it
> actually didn't :-).

Commit a530a8d4ac39 mentions "update", not "fix".

The 'Fixes:' tag is helpful for downstream forks, to cherry-pick
relevant commits.

> 
> Fixes tag for 9a6d6ae8afb is also fine for me.
> 
> Thanks!
> 
> -Zhao
> 

Re: [PATCH] subprojects: Update .gitignore for syn

[Daniel P. Berrangé]

On Tue, Sep 30, 2025 at 03:53:51PM +0800, Zhao Liu wrote:
> The commit a530a8d4ac39 missed to update syn version, this is because
> the code base of its v2 patch has fixed syn version, so that the fix for
> syn were lost during the rebase from v1 to v2.
> 
> To rectify this mistake, update the syn version.
> 
> Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>  subprojects/.gitignore | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/subprojects/.gitignore b/subprojects/.gitignore
> index 58a29f012044..136e30cd99ad 100644
> --- a/subprojects/.gitignore
> +++ b/subprojects/.gitignore
> @@ -19,7 +19,7 @@
>  /proc-macro-error-attr-1.0.4
>  /proc-macro2-1.0.95
>  /quote-1.0.36
> -/syn-2.0.66
> +/syn-2.0.104
>  /unicode-ident-1.0.12

IMHO we should get rid of all the version numbers, and use wildcard
matches instead, to eliminate the bug scenario entirely, as people
will repeatedly forgot to change these versions.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] subprojects: Update .gitignore for syn

[Zhao Liu]

On Tue, Sep 30, 2025 at 09:50:24AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Tue, 30 Sep 2025 09:50:24 +0200
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: Re: [PATCH] subprojects: Update .gitignore for syn
> 
> On 30/9/25 09:53, Zhao Liu wrote:
> > The commit a530a8d4ac39 missed to update syn version, this is because
> > the code base of its v2 patch has fixed syn version, so that the fix for
> > syn were lost during the rebase from v1 to v2.
> > 
> > To rectify this mistake, update the syn version.
> > 
> > Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
> 
> IIUC the subprojects is in commit 9a6d6ae8afb, so:
> 
> Fixes: 9a6d6ae8afb ("subprojects: update proc-macro2 and syn")
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

It's because the subject of a530a8d4ac39 mentioned to fix syn but it
actually didn't :-).

Fixes tag for 9a6d6ae8afb is also fine for me.

Thanks!

-Zhao

Re: [PATCH] subprojects: Update .gitignore for syn

[Zhao Liu]

> IMHO we should get rid of all the version numbers, and use wildcard
> matches instead, to eliminate the bug scenario entirely, as people
> will repeatedly forgot to change these versions.

(Manos had the similar comment before.) 

My thought is that exact matching could help identify outdated
subprojects, notifying developers to clean them up and free up a little
local space?

Regrads,
Zhao

Re: [PATCH] subprojects: Update .gitignore for syn

[Daniel P. Berrangé]

On Tue, Sep 30, 2025 at 04:56:10PM +0800, Zhao Liu wrote:
> > IMHO we should get rid of all the version numbers, and use wildcard
> > matches instead, to eliminate the bug scenario entirely, as people
> > will repeatedly forgot to change these versions.
> 
> (Manos had the similar comment before.) 
> 
> My thought is that exact matching could help identify outdated
> subprojects, notifying developers to clean them up and free up a little
> local space?

If developers want to free up space, the submodules are the least
of the problem, but at the same time easily handled with git commands.
I'd much rather optimize for eliminating this "busy work" of changing
ignored version numbers on every update.

Also if you are switching back & forth between branches, it is likely
that there will be different versions present in the subprojects dir,
and it would be desirable for them all to be ignored by git.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|