From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] rust: hpet: fix fw_cfg handling
Date: Tue, 14 Oct 2025 16:53:03 +0800 [thread overview]
Message-ID: <aO4PbwYHYJeRermA@intel.com> (raw)
In-Reply-To: <20251013165251.1004096-1-pbonzini@redhat.com>
On Mon, Oct 13, 2025 at 06:52:51PM +0200, Paolo Bonzini wrote:
> Date: Mon, 13 Oct 2025 18:52:51 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH] rust: hpet: fix fw_cfg handling
> X-Mailer: git-send-email 2.51.0
>
> HPET ids for fw_cfg are not assigned correctly, because there
> is a read but no write. This is caught by nightly Rust as
> an unused-assignments warning, so fix it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/hw/timer/hpet/src/fw_cfg.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Oops, thanks for this fix.
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2025-10-14 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 16:52 [PATCH] rust: hpet: fix fw_cfg handling Paolo Bonzini
2025-10-14 8:53 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO4PbwYHYJeRermA@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).