From: Zhao Liu <zhao1.liu@intel.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-rust@nongnu.org, "Mads Ynddal" <mads@ynddal.dk>,
"Thomas Huth" <thuth@redhat.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Josh Stone" <jistone@redhat.com>
Subject: Re: [PATCH v2 2/4] rust/hpet: add trace events
Date: Thu, 20 Nov 2025 22:49:04 +0800 [thread overview]
Message-ID: <aR8qYPwzsuCfTliL@intel.com> (raw)
In-Reply-To: <20251119205200.173170-3-stefanha@redhat.com>
On Wed, Nov 19, 2025 at 03:51:58PM -0500, Stefan Hajnoczi wrote:
> Date: Wed, 19 Nov 2025 15:51:58 -0500
> From: Stefan Hajnoczi <stefanha@redhat.com>
> Subject: [PATCH v2 2/4] rust/hpet: add trace events
>
> Implement the same trace events as the C implementation.
>
> Notes:
> - Keep order of hpet_ram_write_invalid_tn_cmp and hpet_ram_write_tn_cmp
> the same as the C implementation.
> - Put hpet_ram_write_timer_id in HPETTimer::write() instead of
> HPETState::decode() so that reads can be excluded.
Yes, these changes are accurate and clear.
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> rust/hw/timer/hpet/Cargo.toml | 1 +
> rust/hw/timer/hpet/meson.build | 1 +
> rust/hw/timer/hpet/src/device.rs | 45 +++++++++++++++++++-------------
> 3 files changed, 29 insertions(+), 18 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2025-11-20 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 20:51 [PATCH v2 0/4] trace: add Rust DTrace/SystemTap SDT support Stefan Hajnoczi
2025-11-19 20:51 ` [PATCH v2 1/4] hpet: remove unused trace events Stefan Hajnoczi
2025-11-20 14:49 ` Zhao Liu
2025-11-19 20:51 ` [PATCH v2 2/4] rust/hpet: add " Stefan Hajnoczi
2025-11-20 14:49 ` Zhao Liu [this message]
2025-11-19 20:51 ` [PATCH v2 3/4] subprojects: add probe crate Stefan Hajnoczi
2025-11-19 20:52 ` [PATCH v2 4/4] tracetool: add Rust DTrace/SystemTap SDT support Stefan Hajnoczi
2025-11-21 10:02 ` [PATCH v2 0/4] trace: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR8qYPwzsuCfTliL@intel.com \
--to=zhao1.liu@intel.com \
--cc=alex.bennee@linaro.org \
--cc=jistone@redhat.com \
--cc=mads@ynddal.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).