From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77E5AEB26EC for ; Tue, 10 Feb 2026 17:13:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vprIm-0003Id-G1; Tue, 10 Feb 2026 12:13:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vprIj-0003Hc-6t for qemu-rust@nongnu.org; Tue, 10 Feb 2026 12:13:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vprIf-0000c4-Uo for qemu-rust@nongnu.org; Tue, 10 Feb 2026 12:13:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770743601; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0T0KGA73IKFHQqZv0vuFmKfRG9p8FzZZAyXAe72A/s0=; b=JPba10xUIkIZCFYhJfJCgOn8O2HSkfLEOCq4ZvWNA4Cl5D2zg3veFP/L9RGuSLKJER7Qoq sa5Fz3a+Xi0yjfTeztXL59Dz4UZSOH9705UFManofGki7wTepazi8NK2ydOGFBSoVN+0dd qs0JRQ+z2FprcWVbHPlZhRv6LlJpO08= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-GBa1GXRPOi6MS4IRJ87Qjw-1; Tue, 10 Feb 2026 12:13:18 -0500 X-MC-Unique: GBa1GXRPOi6MS4IRJ87Qjw-1 X-Mimecast-MFC-AGG-ID: GBa1GXRPOi6MS4IRJ87Qjw_1770743595 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DB8861955F24; Tue, 10 Feb 2026 17:13:14 +0000 (UTC) Received: from redhat.com (unknown [10.44.34.137]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9169A1956056; Tue, 10 Feb 2026 17:13:09 +0000 (UTC) Date: Tue, 10 Feb 2026 17:13:05 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Manos Pitsidianakis , Hanna Reitz , Gerd Hoffmann , Paolo Bonzini , Christian Schoenebeck , "Dr. David Alan Gilbert" , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , devel@lists.libvirt.org, qemu-block@nongnu.org, qemu-rust@nongnu.org, Stefan Weil , Kevin Wolf , Richard Henderson Subject: Re: [PATCH v5 05/24] util: expose qemu_thread_set_name Message-ID: References: <20260108170338.2693853-1-berrange@redhat.com> <20260108170338.2693853-6-berrange@redhat.com> <87cy3dc1pl.fsf@pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87cy3dc1pl.fsf@pond.sub.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-MFC-PROC-ID: ylTViVyCMFVHyOmtO93tYnn5WIu0uM0BEAMADAKvX9Y_1770743595 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On Tue, Jan 13, 2026 at 10:16:06AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The ability to set the thread name needs to be used in a number > > of places, so expose the current impls as public methods. > > > > Reviewed-by: Richard Henderson > > Reviewed-by: Dr. David Alan Gilbert > > Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Daniel P. Berrangé > > --- > > include/qemu/thread.h | 1 + > > util/qemu-thread-posix.c | 26 ++++++++++++++++---------- > > util/qemu-thread-win32.c | 13 ++++++++----- > > 3 files changed, 25 insertions(+), 15 deletions(-) > > > > diff --git a/include/qemu/thread.h b/include/qemu/thread.h > > index 3a286bb3ef..27b888ab0a 100644 > > --- a/include/qemu/thread.h > > +++ b/include/qemu/thread.h > > @@ -215,6 +215,7 @@ void *qemu_thread_join(QemuThread *thread); > > void qemu_thread_get_self(QemuThread *thread); > > bool qemu_thread_is_self(QemuThread *thread); > > G_NORETURN void qemu_thread_exit(void *retval); > > +void qemu_thread_set_name(const char *name); > > > > struct Notifier; > > /** > > diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c > > index 7c985b5d38..b1c127dbe3 100644 > > --- a/util/qemu-thread-posix.c > > +++ b/util/qemu-thread-posix.c > > @@ -329,6 +329,21 @@ static void qemu_thread_atexit_notify(void *arg) > > notifier_list_notify(&thread_exit, NULL); > > } > > > > +void qemu_thread_set_name(const char *name) > > +{ > > + /* > > + * Attempt to set the threads name; note that this is for debug, so > > + * we're not going to fail if we can't set it. > > + */ > > +# if defined(CONFIG_PTHREAD_SETNAME_NP_W_TID) > > + pthread_setname_np(pthread_self(), name); > > +# elif defined(CONFIG_PTHREAD_SETNAME_NP_WO_TID) > > + pthread_setname_np(name); > > +# elif defined(CONFIG_PTHREAD_SET_NAME_NP) > > + pthread_set_name_np(pthread_self(), name); > > +# endif > > +} > > + > > typedef struct { > > void *(*start_routine)(void *); > > void *arg; > > @@ -342,17 +357,8 @@ static void *qemu_thread_start(void *args) > > void *arg = qemu_thread_args->arg; > > void *r; > > > > - /* Attempt to set the threads name; note that this is for debug, so > > - * we're not going to fail if we can't set it. > > - */ > > if (qemu_thread_args->name) { > > -# if defined(CONFIG_PTHREAD_SETNAME_NP_W_TID) > > - pthread_setname_np(pthread_self(), qemu_thread_args->name); > > -# elif defined(CONFIG_PTHREAD_SETNAME_NP_WO_TID) > > - pthread_setname_np(qemu_thread_args->name); > > -# elif defined(CONFIG_PTHREAD_SET_NAME_NP) > > - pthread_set_name_np(pthread_self(), qemu_thread_args->name); > > -# endif > > + qemu_thread_set_name(qemu_thread_args->name); > > } > > QEMU_TSAN_ANNOTATE_THREAD_NAME(qemu_thread_args->name); > > g_free(qemu_thread_args->name); > > qemu_thread_set_name() is factored out. No change in behavior. > > > diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c > > index 9595a5b090..4d2d663a9a 100644 > > --- a/util/qemu-thread-win32.c > > +++ b/util/qemu-thread-win32.c > > @@ -225,6 +225,7 @@ struct QemuThreadData { > > void *arg; > > short mode; > > NotifierList exit; > > + char *name; > > > > /* Only used for joinable threads. */ > > bool exited; > > @@ -266,6 +267,10 @@ static unsigned __stdcall win32_start_routine(void *arg) > > void *(*start_routine)(void *) = data->start_routine; > > void *thread_arg = data->arg; > > > > + if (data->name) { > > + qemu_thread_set_name(data->name); > > + g_clear_pointer(&data->name, g_free); > > + } > > qemu_thread_data = data; > > qemu_thread_exit(start_routine(thread_arg)); > > abort(); > > @@ -316,7 +321,7 @@ void *qemu_thread_join(QemuThread *thread) > > return ret; > > } > > > > -static void set_thread_description(HANDLE h, const char *name) > > +void qemu_thread_set_name(const char *name) > > { > > g_autofree wchar_t *namew = NULL; > > > > @@ -329,7 +334,7 @@ static void set_thread_description(HANDLE h, const char *name) > > return; > > } > > > > - SetThreadDescriptionFunc(h, namew); > > + SetThreadDescriptionFunc(GetCurrentThread(), namew); > > } > > > > void qemu_thread_create(QemuThread *thread, const char *name, > > @@ -344,6 +349,7 @@ void qemu_thread_create(QemuThread *thread, const char *name, > > data->arg = arg; > > data->mode = mode; > > data->exited = false; > > + data->name = g_strdup(name); > > notifier_list_init(&data->exit); > > > > if (data->mode != QEMU_THREAD_DETACHED) { > > @@ -355,9 +361,6 @@ void qemu_thread_create(QemuThread *thread, const char *name, > > if (!hThread) { > > error_exit(GetLastError(), __func__); > > } > > - if (name) { > > - set_thread_description(hThread, name); > > - } > > CloseHandle(hThread); > > > > thread->data = data; > > This delays setting the thread name until the thread runs. Fine, I > guess, but I'd mention it in the commit message. Returning to this, the change is arguably /not/ delaying setting the thread name, but in fact fixing a race condition when settnig the thread name. This existing 'set_thread_description' call is taking place in the parent thread, and at this point in the time the child thread has potentially already been scheduled to run. So if the parent thread was unscheduled, it is possible the child was running without having it name set. This change eliminates that race. This distinction is important enough that I think I'll move this specific change out into its own self-contained commit. > > The new QemuThreadData member @name is non-null only between thread > creation and thread name setting, unlike the other members under > /* Passed to win32_start_routine. */ Worth a comment? Keep it alive > until the thread dies? Entirely up to you. > > Reviewed-by: Markus Armbruster > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|