From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6767FD3774 for ; Wed, 25 Feb 2026 16:34:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvHpe-00085w-8p; Wed, 25 Feb 2026 11:33:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvHpd-00083t-Ca for qemu-rust@nongnu.org; Wed, 25 Feb 2026 11:33:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvHpY-0007rY-4j for qemu-rust@nongnu.org; Wed, 25 Feb 2026 11:33:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772037223; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/aN04mUe2svMCGil7zhSEYLpKVVEjL6+RoMnU5C2DA=; b=IO3O9qhIZlj4v+/0fdmKnZvevxFlFZNw4Ip8qMIV9TpAPeG+eru8tXdlqlOc88Sxu+wgj9 pXOldT0k5LUSMRJQSlSZesFj2l5n1/LgcKRMd3Dsl24K1tOV/GI/fxFXey4t938MgsTjXM xYLcIdndhbm/Xce+f9o4+GLqxonUNeQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-kqiDfouxOZG_R6oMVV_O8A-1; Wed, 25 Feb 2026 11:33:39 -0500 X-MC-Unique: kqiDfouxOZG_R6oMVV_O8A-1 X-Mimecast-MFC-AGG-ID: kqiDfouxOZG_R6oMVV_O8A_1772037217 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0404119560A3; Wed, 25 Feb 2026 16:33:37 +0000 (UTC) Received: from redhat.com (unknown [10.45.225.165]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D7A6A1955D71; Wed, 25 Feb 2026 16:33:31 +0000 (UTC) Date: Wed, 25 Feb 2026 16:33:28 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Manos Pitsidianakis , Stefan Weil , "Dr. David Alan Gilbert" , Pierrick Bouvier , devel@lists.libvirt.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org, qemu-rust@nongnu.org, Paolo Bonzini , Gerd Hoffmann , Christian Schoenebeck , Richard Henderson Subject: Re: [PATCH v6 26/27] util: add support for formatting thread info in messages Message-ID: References: <20260211152508.732487-1-berrange@redhat.com> <20260211152508.732487-27-berrange@redhat.com> <87ecmh3uqp.fsf@pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87ecmh3uqp.fsf@pond.sub.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-MFC-PROC-ID: fqkJLzjFyXncjKZBDdWQl31YiDaR980QSgCObz8BgV8_1772037217 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.734, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.78, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org Sender: qemu-rust-bounces+qemu-rust=archiver.kernel.org@nongnu.org On Thu, Feb 19, 2026 at 11:14:54AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The message context is now extended to be able to include the > > thread ID and thread name, after the program name. On Linux > > the thread ID will match the process TID visible in /proc, > > while on other platforms it will merely be an integer repr > > of the system thread object address/ID. > > > > This changes the output for both error_report and qemu_log, > > when running under the system emulators or the QEMU storage > > daemon. > > Yes: > > $ qemu-system-x86_64 -object tls-creds-x509,id=t0 > qemu-system-x86_64: (1116063:main): Missing 'dir' property value > > I do not like this change. The part in (parenthesis) is gobbledygook > for non-developers. I feel it should be off by default. > > Making it on by default for log message (as shown below) is fine. Hmm, challenging as now we have to distiguish callers when formatting the message prefixes, but I can see your point. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|