From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org, armbru@redhat.com,
marcandre.lureau@redhat.com
Subject: Re: [PATCH v3 13/19] scripts/qapi: pull c_name and lstrip from camel_to_upper to caller
Date: Wed, 10 Jun 2026 22:42:51 +0800 [thread overview]
Message-ID: <ail369d+m8qF69DB@intel.com> (raw)
In-Reply-To: <20260526175618.227743-14-pbonzini@redhat.com>
On Tue, May 26, 2026 at 07:56:12PM +0200, Paolo Bonzini wrote:
> Date: Tue, 26 May 2026 19:56:12 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH v3 13/19] scripts/qapi: pull c_name and lstrip from
> camel_to_upper to caller
> X-Mailer: git-send-email 2.54.0
>
> Allow using camel_to_upper for other languages too.
>
> In particular, the lstrip() is needed to avoid reserved C identifiers,
> for example:
>
> typedef enum __org_qemu_x_Enum {
> __ORG_QEMU_X_ENUM___ORG_QEMU_X_VALUE,
> __ORG_QEMU_X_ENUM__MAX,
> } __org_qemu_x_Enum;
>
> Insulate Rust from this, since underscores have a different meaning
> in Rust (though only for the sake of warnings).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/qapi/common.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2026-06-10 14:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:55 [PATCH v3 00/19] rust: QObject and QAPI bindings Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 01/19] rust/qobject: add basic bindings Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 02/19] subprojects: add serde Paolo Bonzini
2026-06-01 14:47 ` Zhao Liu
2026-05-26 17:56 ` [PATCH v3 03/19] rust/qobject: add Serialize implementation Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 04/19] rust/qobject: add Serializer (to_qobject) implementation Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 05/19] rust/qobject: add Deserialize implementation Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 06/19] rust/qobject: add Deserializer (from_qobject) implementation Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 07/19] rust/qobject: add from/to JSON bindings for QObject Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 08/19] rust/qobject: add Display/Debug Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 09/19] scripts/qapi: reject empty enums Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 10/19] scripts/qapi: enum with conditional first item must be optional Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 11/19] scripts/qapi: add QAPISchemaIfCond.rsgen() Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 12/19] scripts/qapi: add QAPISchemaType.is_predefined Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 13/19] scripts/qapi: pull c_name and lstrip from camel_to_upper to caller Paolo Bonzini
2026-06-10 14:42 ` Zhao Liu [this message]
2026-05-26 17:56 ` [PATCH v3 14/19] scripts/qapi: allow passing multiple segments to mcgen Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 15/19] scripts/qapi: generate high-level Rust bindings Paolo Bonzini
2026-05-26 21:03 ` Marc-André Lureau
2026-06-04 10:11 ` Zhao Liu
2026-06-11 15:23 ` Zhao Liu
2026-06-11 15:33 ` Manos Pitsidianakis
2026-05-26 17:56 ` [PATCH v3 16/19] scripts/rustc_args: add --no-strict-cfg Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 17/19] rust/util: build QAPI types Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 18/19] scripts/qapi: add serde attributes Paolo Bonzini
2026-05-26 17:56 ` [PATCH v3 19/19] rust/tests: QAPI integration tests Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ail369d+m8qF69DB@intel.com \
--to=zhao1.liu@intel.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox