From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: manos.pitsidianakis@linaro.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] configure: Don't disable Rust for too old meson version
Date: Tue, 12 Aug 2025 08:41:42 +0200 [thread overview]
Message-ID: <f85bd476-501a-4693-b830-6ab7a7168d94@redhat.com> (raw)
In-Reply-To: <20250811142923.89983-1-kwolf@redhat.com>
On 8/11/25 16:29, Kevin Wolf wrote:
> If the user explicitly specified --enable-rust, don't just fail if meson
> is too old for Rust support, but do the same thing as if meson was too
> old for the C code: Just download a newer one.
>
> In order to avoid the additional download for people who aren't
> intentionally opting in to Rust, keep the automatic disabling based on
> the meson version as the default if neither --enable-rust nor
> --disable-rust were given.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Are you going to submit the patch yourself?
(By the way, I just discovered that IGVM support is incompatible with
Rust because you end up with two staticlibs... I'm not yet sure how to
fix it, other than by compiling libigvm ourselves).
Paolo
next prev parent reply other threads:[~2025-08-12 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 14:29 [PATCH] configure: Don't disable Rust for too old meson version Kevin Wolf
2025-08-12 6:41 ` Paolo Bonzini [this message]
2025-08-12 12:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85bd476-501a-4693-b830-6ab7a7168d94@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).