From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jU8vP-0007BK-23 for mharc-qemu-trivial@gnu.org; Thu, 30 Apr 2020 09:08:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU8tB-00062D-7s for qemu-trivial@nongnu.org; Thu, 30 Apr 2020 09:08:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU8qW-000173-Sl for qemu-trivial@nongnu.org; Thu, 30 Apr 2020 09:06:04 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:48034 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jU8qW-00016n-C8 for qemu-trivial@nongnu.org; Thu, 30 Apr 2020 09:03:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588251798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f8E8pe4uJFSVCL12YBXfbCIOFNXJWwSkFGUcxoMb0vY=; b=ResWDvWOjo/KpZ6GMnhyrUsSBOFrvNTIL/rL4B5FcPHmX/1CYE+Q+OoVCxTHOx1m3CqFmD lU9zf2fTljHyqCaYOZF0ah7NSDrjJ/vyGt458GO4wQas2fEtEg47lJ0lKROAanCoeIU+Nq sveBuFjyP9i4rjLlHeaYoqd3GzyC3Q4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-JhWeAgEcME2-nVeDX2TtQg-1; Thu, 30 Apr 2020 09:03:16 -0400 X-MC-Unique: JhWeAgEcME2-nVeDX2TtQg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5609F1005510; Thu, 30 Apr 2020 13:03:15 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0FF42855B; Thu, 30 Apr 2020 13:03:08 +0000 (UTC) Message-ID: <01347fa11dedc2eec731c405468eb12081efdd43.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] LUKS: better error message when creating too large files From: Maxim Levitsky To: "Daniel P." =?ISO-8859-1?Q?Berrang=E9?= Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz Date: Thu, 30 Apr 2020 16:03:06 +0300 In-Reply-To: References: <20190721181508.28608-1-mlevitsk@redhat.com> <20190721181508.28608-2-mlevitsk@redhat.com> <20190722090556.GC23775@redhat.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.61; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/30 01:04:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 13:08:21 -0000 On Thu, 2020-04-30 at 15:18 +0300, Maxim Levitsky wrote: > On Mon, 2019-07-22 at 10:05 +0100, Daniel P. Berrang=C3=A9 wrote: > > On Sun, Jul 21, 2019 at 09:15:07PM +0300, Maxim Levitsky wrote: > > > Currently if you attampt to create too large file with luks you > > > get the following error message: > > >=20 > > > Formatting 'test.luks', fmt=3Dluks size=3D17592186044416 key-secret= =3Dsec0 > > > qemu-img: test.luks: Could not resize file: File too large > > >=20 > > > While for raw format the error message is > > > qemu-img: test.img: The image size is too large for file format 'raw' > > >=20 > > >=20 > > > The reason for this is that qemu-img checks for errono of the failure= , > > > and presents the later error when it is -EFBIG > > >=20 > > > However crypto generic code 'swallows' the errno and replaces it > > > with -EIO. > > >=20 > > > As an attempt to make it better, we can make luks driver, > > > detect -EFBIG and in this case present a better error message, > > > which is what this patch does > > >=20 > > > The new error message is: > > >=20 > > > qemu-img: error creating test.luks: The requested file size is too la= rge > > >=20 > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1534898 > > > Signed-off-by: Maxim Levitsky > > > --- > > > block/crypto.c | 25 +++++++++++++++++++++---- > > > 1 file changed, 21 insertions(+), 4 deletions(-) > >=20 > > Reviewed-by: Daniel P. Berrang=C3=A9 >=20 >=20 > Could someone pick to a maintainer tree, now that freeze is over? >=20 >=20 > Best regards, > =09Maxim Levitsky > >=20 > > Regards, > > Daniel >=20 >=20 I replied to an old version, please disregard, Best regards, =09Maxim Levitsky