From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ezS9z-0006zP-UQ for mharc-qemu-trivial@gnu.org; Fri, 23 Mar 2018 15:15:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezS9x-0006xq-M6 for qemu-trivial@nongnu.org; Fri, 23 Mar 2018 15:15:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezS9w-0003aS-PX for qemu-trivial@nongnu.org; Fri, 23 Mar 2018 15:15:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48004 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezS9g-0003Nz-B2; Fri, 23 Mar 2018 15:15:12 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9DC89722E8; Fri, 23 Mar 2018 19:15:01 +0000 (UTC) Received: from [10.36.116.38] (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDE162023233; Fri, 23 Mar 2018 19:14:48 +0000 (UTC) To: Laurent Vivier , qemu-devel@nongnu.org Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Max Filippov , Eric Blake , Alberto Garcia , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Yongbok Kim , Markus Armbruster , Richard Henderson , Fam Zheng , Eduardo Habkost , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, David Gibson , Kevin Wolf , =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= , Peter Crosthwaite , Igor Mitsyanko , Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini References: <20180323143202.28879-1-lvivier@redhat.com> <20180323143202.28879-4-lvivier@redhat.com> From: Thomas Huth Message-ID: <0a6bdc26-5380-e1e7-bf85-f124b4b3f9de@redhat.com> Date: Fri, 23 Mar 2018 20:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180323143202.28879-4-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 23 Mar 2018 19:15:01 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 23 Mar 2018 19:15:01 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [Qemu-ppc] [PATCH v2 3/5] error: Remove NULL checks on error_propagate() calls X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 19:15:30 -0000 On 23.03.2018 15:32, Laurent Vivier wrote: > Re-run Coccinelle patch > scripts/coccinelle/error_propagate_null.cocci > > Signed-off-by: Laurent Vivier > --- > io/channel-websock.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/io/channel-websock.c b/io/channel-websock.c > index ec48a305f0..e6608b969d 100644 > --- a/io/channel-websock.c > +++ b/io/channel-websock.c > @@ -586,9 +586,7 @@ static gboolean qio_channel_websock_handshake_io(QIOChannel *ioc, > return TRUE; > } > > - if (err) { > - error_propagate(&wioc->io_err, err); > - } > + error_propagate(&wioc->io_err, err); > > trace_qio_channel_websock_handshake_reply(ioc); > qio_channel_add_watch( Reviewed-by: Thomas Huth