* [Qemu-trivial] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include
@ 2011-07-04 21:02 Peter Maydell
2011-07-04 21:45 ` [Qemu-trivial] [Qemu-devel] " Alexander Graf
2011-07-12 21:29 ` Blue Swirl
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2011-07-04 21:02 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Remove the include of setjmp.h from the cpu.h of target-alpha
and target-ppc. This is unnecessary because cpu-defs.h already
includes this header; this change brings these two targets
into line with all the rest.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-alpha/cpu.h | 2 --
target-ppc/cpu.h | 2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
index 411bd55..78caa79 100644
--- a/target-alpha/cpu.h
+++ b/target-alpha/cpu.h
@@ -28,8 +28,6 @@
#include "cpu-defs.h"
-#include <setjmp.h>
-
#include "softfloat.h"
#define TARGET_HAS_ICE 1
diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
index 84f8ff6..d903366 100644
--- a/target-ppc/cpu.h
+++ b/target-ppc/cpu.h
@@ -75,8 +75,6 @@
#include "cpu-defs.h"
-#include <setjmp.h>
-
#include "softfloat.h"
#define TARGET_HAS_ICE 1
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include
2011-07-04 21:02 [Qemu-trivial] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include Peter Maydell
@ 2011-07-04 21:45 ` Alexander Graf
2011-07-12 21:29 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2011-07-04 21:45 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On 04.07.2011, at 23:02, Peter Maydell wrote:
> Remove the include of setjmp.h from the cpu.h of target-alpha
> and target-ppc. This is unnecessary because cpu-defs.h already
> includes this header; this change brings these two targets
> into line with all the rest.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Yeah, I actually think no code (unless specifically configure'd for it) should include non-local headers (<...> instead of "..."). Of course that would include device/target specific headers as well ;).
Acked-by: Alexander Graf <agraf@suse.de>
> ---
> target-alpha/cpu.h | 2 --
> target-ppc/cpu.h | 2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index 411bd55..78caa79 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -28,8 +28,6 @@
>
> #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
> #include "softfloat.h"
>
> #define TARGET_HAS_ICE 1
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 84f8ff6..d903366 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -75,8 +75,6 @@
>
> #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
> #include "softfloat.h"
>
> #define TARGET_HAS_ICE 1
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include
2011-07-04 21:02 [Qemu-trivial] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include Peter Maydell
2011-07-04 21:45 ` [Qemu-trivial] [Qemu-devel] " Alexander Graf
@ 2011-07-12 21:29 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2011-07-12 21:29 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
Thanks, applied.
On Tue, Jul 5, 2011 at 12:02 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> Remove the include of setjmp.h from the cpu.h of target-alpha
> and target-ppc. This is unnecessary because cpu-defs.h already
> includes this header; this change brings these two targets
> into line with all the rest.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target-alpha/cpu.h | 2 --
> target-ppc/cpu.h | 2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index 411bd55..78caa79 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -28,8 +28,6 @@
>
> #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
> #include "softfloat.h"
>
> #define TARGET_HAS_ICE 1
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 84f8ff6..d903366 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -75,8 +75,6 @@
>
> #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
> #include "softfloat.h"
>
> #define TARGET_HAS_ICE 1
> --
> 1.7.4.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-12 21:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-04 21:02 [Qemu-trivial] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include Peter Maydell
2011-07-04 21:45 ` [Qemu-trivial] [Qemu-devel] " Alexander Graf
2011-07-12 21:29 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).