From: David Gibson <david@gibson.dropbear.id.au>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH] Correctly assign PCI domain numbers
Date: Mon, 1 Aug 2011 16:51:02 +1000 [thread overview]
Message-ID: <1312181462-29889-1-git-send-email-david@gibson.dropbear.id.au> (raw)
qemu already almost supports PCI domains; that is, several entirely
independent PCI host bridges on the same machine. However, a bug in
pci_bus_new_inplace() means that every host bridge gets assigned domain
number zero and so can't be properly distinguished. This patch fixes the
bug, giving each new host bridge a new domain number.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/pci.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 36db58b..2b4aecb 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -262,6 +262,8 @@ int pci_find_domain(const PCIBus *bus)
return -1;
}
+static int pci_next_domain; /* = 0 */
+
void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent,
const char *name,
MemoryRegion *address_space,
@@ -274,7 +276,8 @@ void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent,
/* host bridge */
QLIST_INIT(&bus->child);
- pci_host_bus_register(0, bus); /* for now only pci domain 0 is supported */
+
+ pci_host_bus_register(pci_next_domain++, bus);
vmstate_register(NULL, -1, &vmstate_pcibus, bus);
}
--
1.7.5.4
next reply other threads:[~2011-08-01 6:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 6:51 David Gibson [this message]
2011-08-01 8:31 ` [Qemu-trivial] [Qemu-devel] [PATCH] Correctly assign PCI domain numbers Isaku Yamahata
2011-08-01 13:32 ` David Gibson
2011-08-01 10:10 ` [Qemu-trivial] " Michael S. Tsirkin
2011-08-01 13:33 ` David Gibson
2011-08-03 10:13 ` Stefan Hajnoczi
2011-08-03 10:21 ` Michael S. Tsirkin
2011-08-10 3:05 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312181462-29889-1-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).