From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RJiB7-0001B1-WB for mharc-qemu-trivial@gnu.org; Fri, 28 Oct 2011 04:52:41 -0400 Received: from eggs.gnu.org ([140.186.70.92]:34310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJiB3-0000rw-75 for qemu-trivial@nongnu.org; Fri, 28 Oct 2011 04:52:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJiB1-0002ev-HV for qemu-trivial@nongnu.org; Fri, 28 Oct 2011 04:52:36 -0400 Received: from oxygen.pond.sub.org ([78.46.104.156]:47090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJiAy-0002di-HB; Fri, 28 Oct 2011 04:52:32 -0400 Received: from blackfin.pond.sub.org (p5B32C8B0.dip.t-dialin.net [91.50.200.176]) by oxygen.pond.sub.org (Postfix) with ESMTPA id D06E39FF71; Fri, 28 Oct 2011 10:52:27 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 500) id 2A4F16006F; Fri, 28 Oct 2011 10:52:27 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Fri, 28 Oct 2011 10:52:25 +0200 Message-Id: <1319791946-15602-2-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.6.4 In-Reply-To: <1319791946-15602-1-git-send-email-armbru@redhat.com> References: <1319791946-15602-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 78.46.104.156 Cc: qemu-trivial@nongnu.org, jvrao@linux.vnet.ibm.com Subject: [Qemu-trivial] [PATCH 1/2] sysbus: Supply missing va_end() X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2011 08:52:38 -0000 C99 7.15.1: Each invocation of the va_start and va_copy macros shall be matched by a corresponding invocation of the va_end macro in the same function. Spotted by Coverity. Harmless on the (common) systems where va_end() does nothing. Signed-off-by: Markus Armbruster --- hw/sysbus.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 4fab5a4..fd2fc6a 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -198,6 +198,7 @@ DeviceState *sysbus_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } @@ -229,6 +230,7 @@ DeviceState *sysbus_try_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } -- 1.7.6.4