* [Qemu-trivial] [PATCH] qdev: Fix crash on -device '?=x'
@ 2011-11-08 10:00 Markus Armbruster
2011-11-08 10:52 ` [Qemu-trivial] [Qemu-devel] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2011-11-08 10:00 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/qdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 50976dd..106407f 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -186,7 +186,7 @@ int qdev_device_help(QemuOpts *opts)
return 1;
}
- if (!qemu_opt_get(opts, "?")) {
+ if (!driver || !qemu_opt_get(opts, "?")) {
return 0;
}
--
1.7.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev: Fix crash on -device '?=x'
2011-11-08 10:00 [Qemu-trivial] [PATCH] qdev: Fix crash on -device '?=x' Markus Armbruster
@ 2011-11-08 10:52 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-11-08 10:52 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-trivial, qemu-devel
On Tue, Nov 08, 2011 at 11:00:38AM +0100, Markus Armbruster wrote:
> Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/qdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-08 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08 10:00 [Qemu-trivial] [PATCH] qdev: Fix crash on -device '?=x' Markus Armbruster
2011-11-08 10:52 ` [Qemu-trivial] [Qemu-devel] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).